Last modified: 2010-05-15 15:38:44 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
Bug 1366 - A certain text substitution does not work (e.g. in Enotif message text)
A certain text substitution does not work (e.g. in Enotif message text)
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Special pages (Other open bugs)
1.5.x
All All
: Normal normal (vote)
: ---
Assigned To: Antoine "hashar" Musso (WMF)
http://meta.wikipedia.org/Enotif
: patch
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2005-01-19 19:38 UTC by T. Gries
Modified: 2010-05-15 15:38 UTC (History)
1 user (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description T. Gries 2005-01-19 19:38:46 UTC
Using E-mail notification http://bugzilla.wikipedia.org/show_bug.cgi?id=454 of
CVS HEAD of today, ENotif e-mails are sent out which are not correctly composed
(in a certain line), see

example of a WRONG ENOTIF MAIL:
"...See
http://myserver/phase3/index.php?title=%24PAGETITLE_RAWURL&diff=0&oldid=$OLDID
for all changes since "

Solution:

A two-level string substitution is needed, which were lost by the CVS commit in
December. 
TO FIX THIS, please change in UserMailer.php (add one line)
===========================================================

	# regarding the use of oldid as an indicator for the last visited version, see also
		# http://bugzilla.wikipeda.org/show_bug.cgi?id=603 "Delete + undelete cycle
doesn't preserve old_id"
		# However, in the case of a new page which is already watched, we have no
previous version to compare
		if( $article->mOldid ) {
			$keys['$NEWPAGE'] = wfMsg( 'email_notification_lastvisitedrevisiontext' );
			$keys['$OLDID']   = $article->mOldid;
		} else {
			$keys['$NEWPAGE'] = wfMsg( 'email_notification_newpagetext' );
			# clear $OLDID placeholder in the message template
			$keys['$OLDID']   = '';
		}

# LINE 271:
		$body = strtr( $body, $keys );  // <<<<<---- ADD THIS HERE

		$pagetitle = $article->mTitle;


Please can anyone of the core developers add the indicated line in
UserMailer.php , thanks

Tom aka Wikinaut
- for ENotif

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links