Last modified: 2010-05-15 15:38:44 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T3366, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 1366 - A certain text substitution does not work (e.g. in Enotif message text)
A certain text substitution does not work (e.g. in Enotif message text)
Product: MediaWiki
Classification: Unclassified
Special pages (Other open bugs)
All All
: Normal normal (vote)
: ---
Assigned To: Antoine "hashar" Musso (WMF)
: patch
Depends on:
  Show dependency treegraph
Reported: 2005-01-19 19:38 UTC by T. Gries
Modified: 2010-05-15 15:38 UTC (History)
1 user (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Description T. Gries 2005-01-19 19:38:46 UTC
Using E-mail notification of
CVS HEAD of today, ENotif e-mails are sent out which are not correctly composed
(in a certain line), see

example of a WRONG ENOTIF MAIL:
for all changes since "


A two-level string substitution is needed, which were lost by the CVS commit in
TO FIX THIS, please change in UserMailer.php (add one line)

	# regarding the use of oldid as an indicator for the last visited version, see also
		# "Delete + undelete cycle
doesn't preserve old_id"
		# However, in the case of a new page which is already watched, we have no
previous version to compare
		if( $article->mOldid ) {
			$keys['$NEWPAGE'] = wfMsg( 'email_notification_lastvisitedrevisiontext' );
			$keys['$OLDID']   = $article->mOldid;
		} else {
			$keys['$NEWPAGE'] = wfMsg( 'email_notification_newpagetext' );
			# clear $OLDID placeholder in the message template
			$keys['$OLDID']   = '';

# LINE 271:
		$body = strtr( $body, $keys );  // <<<<<---- ADD THIS HERE

		$pagetitle = $article->mTitle;

Please can anyone of the core developers add the indicated line in
UserMailer.php , thanks

Tom aka Wikinaut
- for ENotif

Note You need to log in before you can comment on or make changes to this bug.