Last modified: 2008-04-16 19:59:46 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T15632, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 13632 - Diffs do not show changes in whitespace (wikidiff2)
Diffs do not show changes in whitespace (wikidiff2)
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
wikidiff2 (Other open bugs)
unspecified
All All
: Normal normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2008-04-06 20:26 UTC by Omegatron
Modified: 2008-04-16 19:59 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Omegatron 2008-04-06 20:26:31 UTC 
In bug 286 it was said that adding an underline to the .diffchange CSS would fix this, but it does not, since the whitespace is not surrounded by the diffchange class.

1. If I change "some words" to "some     words", the HTML for the diff view has the extra spaces, but they are collapsed by the browser.  For the diff view, multiple spaces need to be forced with alternating nbsp; so that they do not collapse on display.  ("some    words" needs to become "some    words")
2. Anything that changes needs to be wrapped with the diffchange class, including whitespace, so that we can highlight it with an underline.
Comment 1 Brion Vibber 2008-04-09 00:03:57 UTC 
Seems to work fine on MediaWiki trunk.

Probably the change needs to be applied to the wikidiff2 plugin we use on Wikimedia sites.
Comment 2 Omegatron 2008-04-09 00:09:24 UTC 
(In reply to comment #1)
> Seems to work fine on MediaWiki trunk.

Does it do both 1 and 2?
Comment 3 Alexandre Emsenhuber [IAlex] 2008-04-12 18:45:10 UTC 
changed Product/Component to MediaWiki extensions/wikidiff2
Comment 4 Niklas Laxström 2008-04-16 19:59:46 UTC 
Added pre-wrap styles to diff.css and classes to wikidiff2 in r33451.
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links