Last modified: 2010-05-15 15:37:46 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
Bug 1363 - Enotif Reset Nofication Flags does not work
Enotif Reset Nofication Flags does not work
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Special pages (Other open bugs)
1.5.x
All All
: Normal normal (vote)
: ---
Assigned To: Antoine "hashar" Musso (WMF)
http://meta.wikipedia.org/Enotif
: patch
Depends on:
Blocks: 1932
  Show dependency treegraph
 
Reported: 2005-01-19 15:41 UTC by Dieter Menne
Modified: 2010-05-15 15:37 UTC (History)
1 user (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Dieter Menne 2005-01-19 15:41:24 UTC
In SpecialWatchlist, clearAllNotifcations() has no arguments, so it always
returns immediately.
The solution below seems to work:

	if( $wgRequest->getVal( 'reset' ) == 'all' ) {
		$wgUser->clearAllNotifications($uid); // Menne, added $uid
	}
Comment 1 T. Gries 2005-01-19 19:08:41 UTC
(In reply to comment #0)
> In SpecialWatchlist, clearAllNotifcations() has no arguments, so it always
> returns immediately.
> The solution below seems to work:
> 
> 	if( $wgRequest->getVal( 'reset' ) == 'all' ) {
> 		$wgUser->clearAllNotifications($uid); // Menne, added $uid
> 	}

I confirm Dieter's observation.

Please can someone of the core developers change this in CVS HEAD ? Thanks; I do
not have CVS access rights.

I checked today's CVS HEAD, it works fine.

Tom aka Wikinaut
- for Enotif
Comment 2 Dieter Menne 2005-01-20 07:52:15 UTC
I don't really recommend my fix from a design point of view, it only was a quick fix. Passing 
the UID to a class that "knows" the user is no clean design. Better change the definition of 
clearAllNotification to taking no parameters and extracting the uid from itself. 

This is probably what Brion had in mind when he (not Tom) remove the parameter, but it was not 
followed up by changes in the user class.
Comment 3 T. Gries 2005-01-20 08:03:19 UTC
(In reply to comment #2)
> I don't really recommend my fix from a design point of view, it only was a
quick fix. Passing 
> the UID to a class that "knows" the user is no clean design. Better change the
definition of 
> clearAllNotification to taking no parameters and extracting the uid from itself. 
> 
> This is probably what Brion had in mind when he (not Tom) remove the
parameter, but it was not 
> followed up by changes in the user class.

Yes, this should also be adapted accordingly.
Tom
- for ENotif

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links