Last modified: 2008-08-08 22:43:14 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
Bug 13629 - Flagged Revision Box is above categories
Flagged Revision Box is above categories
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
FlaggedRevs (Other open bugs)
unspecified
All All
: Low enhancement with 2 votes (vote)
: ---
Assigned To: Nobody - You can work on this!
http://de.labs.wikimedia.org/wiki/Wik...
: patch, patch-need-review
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2008-04-06 16:53 UTC by P. Birken
Modified: 2008-08-08 22:43 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
Patch for moving rating box below categories (5.67 KB, patch)
2008-04-22 10:53 UTC, Daniel Arnold
Details

Description P. Birken 2008-04-06 16:53:06 UTC
Categories are a part of the content of an article. Therefore, the flagging box should be below the categories, not above (see also http://de.labs.wikimedia.org/wiki/Websiteentwicklung:_CSS:_Einbau_in_HTML/XML). 

And please treat this with low priority ;-)
Comment 1 Aaron Schulz 2008-04-15 11:47:05 UTC
This would require an extensive skin change to add a point that is always in the bottom of the article and above any categories.
Comment 2 Daniel Arnold 2008-04-22 00:02:58 UTC
If have a working solution for all skins (no skin change required :-). I'll clean it up a bit and submit it here tomorrow.
Comment 3 Daniel Arnold 2008-04-22 10:53:50 UTC
Created attachment 4832 [details]
Patch for moving rating box below categories

This patch moves the rating box below categories in case of SkinTemplate.php based skins, which all have the categories below the text.

Older skins (such as CologneBlue) have the categories above the text and don't have the SkinTemplate-Hook. Thus the old behaviour (rating box directly below text) is preserved for these skins.

I also removed a "$skin = $wgUser->getSkin();" which seemed to me like forgotten.

I hope I didn't make anything wrong with all these objects. At least it works for me. :-) Some optical (CSS) quirks I have seen (and introduced with my older patches) will be fixed with a separate patch.
Comment 4 Aaron Schulz 2008-04-22 15:34:43 UTC
I don't like the hack of setting the category area to itself plus the form:

$output->set( 'catlinks', $output->data[ 'catlinks' ] . $form );

The output set method is very clear that it wants category links, not links and some other random HTML.
Comment 5 Daniel Arnold 2008-04-24 10:10:19 UTC
What hack? The skin template hook is meant for those cases where you need to extend the skin template in a way the skin template authors didn't think about. I also don't see how this can create any troubles in future. For example if you look at the HTML output the code is placed exactly in the right place. Beside I did care a lot that it works correctly in all available skins.
Comment 6 Aaron Schulz 2008-05-06 14:42:13 UTC
Should be done during skin refactoring.
Comment 7 Leon Weber 2008-08-08 17:38:59 UTC
We've implemented a new hook 'SkinAfterContent' that allows to resolve this nicely. The same hook can be used for all skins and it's purpose it not for categories but more generically for any data. We're modifying FlaggedRevs now so the box is placed below the content.
Comment 8 Leon Weber 2008-08-08 22:43:14 UTC
Fixed in SVN trunk, r38962. Implemented in a way suggested by aaron in comments 4 and 6.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links