Last modified: 2008-08-08 22:43:14 UTC
Categories are a part of the content of an article. Therefore, the flagging box should be below the categories, not above (see also http://de.labs.wikimedia.org/wiki/Websiteentwicklung:_CSS:_Einbau_in_HTML/XML).
And please treat this with low priority ;-)
This would require an extensive skin change to add a point that is always in the bottom of the article and above any categories.
If have a working solution for all skins (no skin change required :-). I'll clean it up a bit and submit it here tomorrow.
Created attachment 4832 [details]
Patch for moving rating box below categories
This patch moves the rating box below categories in case of SkinTemplate.php based skins, which all have the categories below the text.
Older skins (such as CologneBlue) have the categories above the text and don't have the SkinTemplate-Hook. Thus the old behaviour (rating box directly below text) is preserved for these skins.
I also removed a "$skin = $wgUser->getSkin();" which seemed to me like forgotten.
I hope I didn't make anything wrong with all these objects. At least it works for me. :-) Some optical (CSS) quirks I have seen (and introduced with my older patches) will be fixed with a separate patch.
I don't like the hack of setting the category area to itself plus the form:
$output->set( 'catlinks', $output->data[ 'catlinks' ] . $form );
The output set method is very clear that it wants category links, not links and some other random HTML.
What hack? The skin template hook is meant for those cases where you need to extend the skin template in a way the skin template authors didn't think about. I also don't see how this can create any troubles in future. For example if you look at the HTML output the code is placed exactly in the right place. Beside I did care a lot that it works correctly in all available skins.
Should be done during skin refactoring.
We've implemented a new hook 'SkinAfterContent' that allows to resolve this nicely. The same hook can be used for all skins and it's purpose it not for categories but more generically for any data. We're modifying FlaggedRevs now so the box is placed below the content.
Fixed in SVN trunk, r38962. Implemented in a way suggested by aaron in comments 4 and 6.