Last modified: 2014-09-11 18:20:41 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
Bug 13512 - CentralAuthUser::chooseHomeWiki gets confused if all privileged accounts are blocked
CentralAuthUser::chooseHomeWiki gets confused if all privileged accounts are ...
Status: RESOLVED WORKSFORME
Product: MediaWiki extensions
Classification: Unclassified
CentralAuth (Other open bugs)
unspecified
All All
: Normal enhancement (vote)
: ---
Assigned To: Nobody - You can work on this!
:
: 13671 (view as bug list)
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2008-03-25 22:28 UTC by Brion Vibber
Modified: 2014-09-11 18:20 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Brion Vibber 2008-03-25 22:28:49 UTC
When choosing the home wiki, if any accounts are in privileged groups, only the privileged accounts are considered for the home selection.

However, any blocked accounts are removed *after* this check. If all the privileged accounts are blocked at the moment (for instance, a sysop account who has blocked himself temporarily), the working set ends up being empty, no home wiki is chosen, and an exception is thrown.


The simplest solution is probably to strike out the blocked accounts before the privileged check; that is, just ignore any blocked accounts. This would, however, potentially allow a non-priveleged account to take advantage of a temporary or accidental block of a sysop account to take over.

If it's desired to block that condition, then a more friendly error should be returned instead of the low-level exception.
Comment 1 Brion Vibber 2008-04-09 20:35:16 UTC
*** Bug 13671 has been marked as a duplicate of this bug. ***
Comment 2 Thomas "Tango" Dalton 2008-04-09 20:57:32 UTC
I swear I searched for dupes before reporting - is bugzilla's search function broken? It didn't seem to find any bugs in this component.
Comment 3 Brion Vibber 2008-04-09 21:20:41 UTC
Not broken, just sucks. ;)
Comment 4 Thomas "Tango" Dalton 2008-04-09 21:22:10 UTC
Interesting distinction. I searched for any open bugs in this component whose summaries included the word "privileged" - how did this bug not come up? (I then searched for any bugs in this component and it still found nothing...)
Comment 5 Brion Vibber 2008-04-09 21:56:51 UTC
Considering that I usually have to try four times and use a spell checker to spell 'privileged', I wouldn't be too surprised. :)
Comment 6 Thomas "Tango" Dalton 2008-04-09 22:25:20 UTC
I'll admit to looking it up...
Comment 7 Bugmeister Bot 2011-08-19 19:12:59 UTC
Unassigning default assignments. http://article.gmane.org/gmane.science.linguistics.wikipedia.technical/54734
Comment 8 Kunal Mehta (Legoktm) 2014-06-28 22:33:27 UTC
Was this fixed with I32384d6423d3cb633f99cdcd2745f8ce6d8c597e? I don't see anything in CentralAuthUser::chooseHomeWiki that has to do with blocks.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links