Last modified: 2008-08-28 00:06:15 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
Bug 13471 - Add NUMBEROFROLLBACKERS magic word
Add NUMBEROFROLLBACKERS magic word
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Interface (Other open bugs)
unspecified
All All
: Normal enhancement (vote)
: ---
Assigned To: Nobody - You can work on this!
http://en.wikipedia.org/wiki/Template...
: patch, patch-need-review
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2008-03-21 16:57 UTC by X!
Modified: 2008-08-28 00:06 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
Proposed patch (1.54 KB, patch)
2008-03-21 16:57 UTC, X!
Details
Better patch (1.56 KB, patch)
2008-03-21 17:02 UTC, X!
Details
New patch, implementing {{NUMBERINGROUP}} parserfunction (2.80 KB, patch)
2008-08-27 23:21 UTC, X!
Details
Sigh, fix spaces (2.47 KB, patch)
2008-08-27 23:59 UTC, X!
Details

Description X! 2008-03-21 16:57:12 UTC
On enwiki, the user group rollbackers is enabled. So, a template was created (see URL), because there was no magic word for the amount of rollbackers. SQLBot currently updates it. I have submitted a patch, which updates SiteStats.php and Parser.php, creating that new magic word. I have tested it, and it works. All it needs is to be implemented. Thanks!

Soxred93
Comment 1 X! 2008-03-21 16:57:40 UTC
Created attachment 4744 [details]
Proposed patch
Comment 2 Aryeh Gregor (not reading bugmail, please e-mail directly) 2008-03-21 17:01:58 UTC
1) Your patch seems to mix up rollbackers and bureaucrats.  It looks as though it will result in a fatal error, since you called a nonexistent function SiteStats::crats().

2) The word 'rollbacker' must occur nowhere in the patch.  We will not incorporate explicit references to usergroups that do not exist in the core software.  Generalize this to a NUMBERINGROUP function or something, and it might be committed.
Comment 3 X! 2008-03-21 17:02:45 UTC
Created attachment 4745 [details]
Better patch

(used wrong patch)
Comment 4 Random832 2008-03-21 17:05:07 UTC
Why not just have [[Template:NUMBEROFROLLBACKERS]] and have people update it manually whenever someone gets it? It worked for Pokémon.
Comment 5 Aryeh Gregor (not reading bugmail, please e-mail directly) 2008-03-21 17:07:32 UTC
It's still not acceptable to refer to enwiki-specific groups like that in core code.

This also may be a performance issue for potentially very large groups like rollbacker.  Over time I expect it will grow to tens of thousands or more, and all those index nodes will have to be scanned.  If this feature is really desired, another usergroup table could be added to store the size of each usergroup, like the new category table, but that seems pretty excessive.
Comment 6 X! 2008-03-21 17:15:35 UTC
Ok, working on {{NUMBEROFGROUPUSERS:rollbacker}} now.
Comment 7 X! 2008-03-22 02:31:07 UTC
One thing you might not have noticed: This is for Wikimedia, not MediaWiki.
Comment 8 MZMcBride 2008-03-22 02:39:53 UTC
Corrected component. It should be MediaWiki.
Comment 9 Aryeh Gregor (not reading bugmail, please e-mail directly) 2008-03-23 00:48:27 UTC
Correct.  All software changes are filed under either MediaWiki or MediaWiki extensions, because that's where the changes must be made.  Wikimedia is only for configuration changes, which this is not.  In principle, Wikimedia does not maintain live hacks: everything gets committed to the core software.  (In practice some admins do maintain live hacks, which periodically get cleaned up and committed to avoid merge conflicts on svn up.)
Comment 10 Aryeh Gregor (not reading bugmail, please e-mail directly) 2008-03-25 00:41:37 UTC
Um?  Any reason for RESOLVED LATER?  If someone wants to work on this they can.  LATER should usually be used on MediaWiki bugs for when the bug cannot be fixed now for some reason no matter what code we write (for instance, inadequate upstream support for something) but may be fixable at some later date.
Comment 11 X! 2008-03-25 00:42:50 UTC
Oh, sorry. I thought that meant like a withdrawal or something.
Comment 12 Aryeh Gregor (not reading bugmail, please e-mail directly) 2008-03-25 00:49:00 UTC
You can un-assign yourself using "Reassign bug to default assignee and add Default CC of selected component".  That's not really resolving the issue, though, is it?  It doesn't set it to RESOLVED, it sets it to NEW.
Comment 13 X! 2008-08-27 23:21:16 UTC
Created attachment 5219 [details]
New patch, implementing {{NUMBERINGROUP}} parserfunction

New patch:

Instead of {{NUMBEROFROLLBACKERS}}, it has been changed to {{NUMBERINGROUP}}

Usage: {{NUMBERINGROUP:(group)}}
Raw: {{NUMBERINGROUP:(group)|R}}
Comment 14 X! 2008-08-27 23:59:46 UTC
Created attachment 5220 [details]
Sigh, fix spaces
Comment 15 Roan Kattouw 2008-08-28 00:06:15 UTC
Applied in r40116

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links