Last modified: 2008-03-20 00:33:39 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
Bug 13440 - Enhanced Recent changes / Watchlist display has unpaired parentheses
Enhanced Recent changes / Watchlist display has unpaired parentheses
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Special pages (Other open bugs)
unspecified
All All
: Normal minor (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2008-03-20 00:21 UTC by Mormegil
Modified: 2008-03-20 00:33 UTC (History)
1 user (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Mormegil 2008-03-20 00:21:15 UTC
The recent r32037 broke the display of recent changes / watchlist. Especially the

@@ -492,25 +586,25 @@

 			$r .= ' (';

-			if( $isnew ) {
+			if( !ChangesList::userCan($rcObj,Revision::DELETED_TEXT) ) {
+			    $r .= $nchanges[$n];
+			} else if( $isnew ) {
 				$r .= $nchanges[$n];
 			} else {
 				$r .= $this->skin->makeKnownLinkObj( $block[0]->getTitle(),
 					$nchanges[$n], $curIdEq."&diff=$currentRevision&oldid=$oldid" );
 			}

-			$r .= ') . . ';
-
 			if( $wgRCShowChangedSize ) {
 				# Character difference
 				$chardiff = $rcObj->getCharacterDifference( $block[ count( $block ) - 1 ]->mAttribs['rc_old_len'],
 						$block[0]->mAttribs['rc_new_len'] );
 				if( $chardiff == '' ) {
-					$r .= ' (';
+					$r .= ') ';
 				} else {
 					$r .= ' ' . $chardiff. ' . . ';
 				}
-			}	
+			}

 			# History
 			$r .= '(' . $this->skin->makeKnownLinkObj( $block[0]->getTitle(),

part: Because getCharacterDifference() result already contains parentheses, the result of this change is that a line in Enhanced RC/WL contains an unpaired paren (“(2 changes (-8)”).

(Also, I don’t consider literal “style=font-size:95%;” to be a great idea, but that is not that important.)
Comment 1 Aaron Schulz 2008-03-20 00:33:39 UTC
Fixed in r32194. Hard-coded font size was a testing relic; removed that too.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links