Last modified: 2010-05-15 15:33:45 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T3344, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 1344 - RFC magic highlighting should not happen within [links]
RFC magic highlighting should not happen within [links]
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Parser (Other open bugs)
1.4.x
All All
: Low minor (vote)
: ---
Assigned To: Nobody - You can work on this!
:
: 3415 (view as bug list)
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2005-01-16 19:54 UTC by Colin Pitts
Modified: 2010-05-15 15:33 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
Parser test cases (892 bytes, patch)
2006-08-16 06:29 UTC, Wil Mahan
Details

Description Colin Pitts 2005-01-16 19:54:09 UTC
Currently, MediaWiki's parser.php contains the special function magicRFC(),
which transforms raw text containing 'RFC' followed by a number into a link
specified by MediaWiki:Rfcurl.

This complicates parsing for a relatively rare case, and should be removed.

The functionality could be replaced by the existing RFC InterWiki map entry.
This would require a substitution script to be run across existing databases to
update current links.
Comment 1 Donald Lancon 2005-05-29 02:40:19 UTC
Here's an example at the English Wikipedia: http://en.wikipedia.org/wiki/RFC_3377

In case someone changes the page, here's the relevant part (called by the
template {{Compu-network-stub}}):

  ''This [[computer network]]-related article is a [[Wikipedia:Perfect stub
article|stub]].
  [[Wikipedia:Find or fix a stub|Help]] Wikipedia by
  [{{SERVER}}{{localurl:{{NAMESPACE}}:{{PAGENAME}}|action=edit}} expanding it]''

Since RFC's are autolinked, this is rendered on-screen like this:

  This computer network-related article is a stub. Help Wikipedia by
  RFC 3377&action=edit">expanding it.

The text "RFC 3777" is linked to:

  http://en.wikipedia.org/w/index.php?title=RFC_3377&action=edit

and so actually works (in Windows Firefox 1.0 and IE 5.5, anyway), but a check
of the HTML source reveals a little more about what's happening:

by <a href="http://en.wikipedia.org/w/index.php?title=RFC_3377&amp;action=edit"
class='external'
title="http://en.wikipedia.org/w/index.php?title=&lt;ahref='http://www.ietf.org/rfc/rfc3377.txt'
class='external' title=">RFC 3377</a>&amp;action=edit"&gt;expanding it

I hope that gets displayed correctly when I save this comment!  Anyway, the
software is still trying to autolink the RFC to the page at ietf.org, as it
would if you just had the string "RFC 3377" in running text.  But obviously it
shouldn't be doing that since it's inside of a URL.
Comment 2 Donald Lancon 2005-05-29 02:47:04 UTC
Note: As far as I can tell, the HTML source shown above is correct.
Comment 3 Christoph Burgmer 2005-08-06 13:20:32 UTC
ISBN passages are also highlighted. Generaly software shouldn't be to intelligent here, as it 
can complicate text editing. Could be integrated with some thing a la {{isbn|...}}. 
Comment 4 Zigger 2005-09-13 23:15:12 UTC
*** Bug 3415 has been marked as a duplicate of this bug. ***
Comment 5 Zigger 2005-09-13 23:18:19 UTC
(In reply to comment #1)
>...
> Since RFC's are autolinked, this is rendered on-screen like this:
> 
>   This computer network-related article is a stub. Help Wikipedia by
>   RFC 3377&action=edit">expanding it.
>...

This problem has been reported as bug 3415.
Comment 6 Baylink@en 2005-12-30 04:10:09 UTC
This bug also surfaces when one tries to force a single-bracket out-link around
an RFC NNNN text string: the result is a null-text link pointing to the
specified site, followed by the magic link as usual.

EG: [http://baylink.pitas.com RFC 2100]

The required workaround is currently [http://baylink.pitas.com <nowiki>RFC
2100</nowiki>]; thanks to robchurch@IRC for suggesting it.  This is indeed a low
priority bug, but if anyone's crawling around inside the parser... :-)

But it's not an RFE; it's a bug.  Changing severity.
Comment 7 Rob Church 2005-12-30 04:54:29 UTC
(In reply to comment #6)
> but if anyone's crawling around inside the parser...

...then I pity their eternal soul ;-)
Comment 8 Wil Mahan 2006-08-16 06:29:05 UTC
Created attachment 2231 [details]
Parser test cases

It looks like Tim Starling fixed the problems in r15976. Here are a couple of
parser test cases for this and bug 3415 (both pass).
Comment 9 Aryeh Gregor (not reading bugmail, please e-mail directly) 2006-08-17 22:33:18 UTC
*** Bug 3415 has been marked as a duplicate of this bug. ***

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links