Last modified: 2011-03-13 18:04:51 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
Bug 13394 - show changes from old revision makes diff from newest revision
show changes from old revision makes diff from newest revision
Product: MediaWiki
Classification: Unclassified
History/Diffs (Other open bugs)
All All
: Lowest enhancement (vote)
: ---
Assigned To: Nobody - You can work on this!
Depends on:
  Show dependency treegraph
Reported: 2008-03-16 17:03 UTC by CBM
Modified: 2011-03-13 18:04 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Description CBM 2008-03-16 17:03:27 UTC
When you edit a previous version of a page, so that the warning about editing an old version of the page appears, and then use the "show changes" button, the diff is generated using the newest version of the page, rather than the original source code of version of the page that is being edited. It would be helpful to have the ability to make a diff from the original text being edited.
Comment 1 Robert Leverington 2008-03-16 17:14:02 UTC
Show Changes should show what your edit will change, therefore by definition it should be a diff against the current revision -- the current functionality is both intuitive and useful, changing it would cause confusion and clutter the interface. Closing as WONTFIX.
Comment 2 CBM 2008-03-16 17:55:50 UTC
"Show changes" reads equally well as "show what has been changed in the edit box". In other words, show what changes have been made since the edit link was selected. I filed this bug because the current functionality didn't do what I expected it to when I was trying to figure out whether some text had been copied directly from an old revision of an article. 
Comment 3 Aryeh Gregor (not reading bugmail, please e-mail directly) 2008-03-16 18:03:33 UTC
I provisionally agree with MinuteElectron that the correct behavior here is to show what changes the edit will cause when you hit "save".  It's arguable, though.  Currently we basically just treat editing an old version like editing the current version and pasting in the old text.  That might not be the most obvious way to handle things, but changing it would be a fairly big project, and at least right now it's very simple and consistent once you understand how it works (which can be summarized in about ten words, as I just did).
Comment 4 Brion Vibber 2008-03-17 22:26:03 UTC
The way it's supposed to work is to show you the changes you're going to save, so indeed I have to agree that the current behavior is correct.

Note You need to log in before you can comment on or make changes to this bug.