Last modified: 2010-05-15 16:03:35 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
Bug 13323 - ArticleSave family of hooks has unused parameters
ArticleSave family of hooks has unused parameters
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Page editing (Other open bugs)
1.13.x
All All
: Normal enhancement (vote)
: ---
Assigned To: Nobody - You can work on this!
http://www.mediawiki.org/wiki/Manual:...
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2008-03-11 14:20 UTC by Christian Neubauer
Modified: 2010-05-15 16:03 UTC (History)
1 user (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Christian Neubauer 2008-03-11 14:20:20 UTC
The parameters $watch and $sectionanchor in the ArticleSave family of hooks are not used.  When the hooks are called in Article->doEdit, null is passed for both parameters.

1) These fields should be marked deprecated in the code or better yet just removed.
2) Authors of extensions using these hooks (http://www.mediawiki.org/wiki/Category:ArticleSave_extensions) should be notified.
3) hooks.txt should be updated.
4) The mediawiki.org pages for the hooks should be updated.
Comment 1 Chad H. 2009-08-03 17:56:10 UTC
I can't find any $sectionanchor (just $section) or $watch. Seems to have been originally fixed in r14834 by Tim (changing two params to null), which haven't come back since. Going ahead and marking this FIXED, unless there's some outstanding issue.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links