Last modified: 2010-05-15 14:35:54 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T3328, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 1328 - Installation refers to Turke MMcache. But this is now superseded by eAccelerator.
Installation refers to Turke MMcache. But this is now superseded by eAcceler...
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Installer (Other open bugs)
unspecified
All All
: Normal normal (vote)
: ---
Assigned To: Jamie Bliss
: patch
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2005-01-14 06:49 UTC by PS
Modified: 2010-05-15 14:35 UTC (History)
1 user (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
A patch to includes/ObjectCache.php to add the eAccelBagOStuff class. (843 bytes, patch)
2005-01-16 20:14 UTC, Jamie Bliss
Details
A patch to includes/Setup.php to use the eAccelBagOStuff class. (189 bytes, patch)
2005-01-16 20:18 UTC, Jamie Bliss
Details
A patch to config/index.php to use the eAccelBagOStuff class. (743 bytes, patch)
2005-01-16 20:22 UTC, Jamie Bliss
Details
Patch for config/index.php, CVS version 1.93 (2.40 KB, patch)
2005-02-23 22:29 UTC, Jamie Bliss
Details
Patch for includes/DefaultSettings.php, CVS version 1.249 (1.41 KB, patch)
2005-02-23 22:30 UTC, Jamie Bliss
Details
Patch for includes/ObjectCache.php, CVS version 1.15 (1.22 KB, patch)
2005-02-23 22:31 UTC, Jamie Bliss
Details
Patch for includes/Setup.php, CVS version 1.117 (648 bytes, patch)
2005-02-23 22:32 UTC, Jamie Bliss
Details
Patch for includes/Setup.php, CVS version 1.117 (2.40 KB, patch)
2005-03-02 01:22 UTC, Jamie Bliss
Details
Patch for config/index.php, CVS version 1.93 (2.42 KB, patch)
2005-03-02 01:31 UTC, Jamie Bliss
Details

Description PS 2005-01-14 06:49:03 UTC
Turke MMcache has ceased development. It does not work with PHP 4.3.10, PHP 5, 
or above.  The live fork is now known as eAccelerator (eaccelerator.sf.net), 
currently in beta testing. 

The installation page for Mediawiki should certainly report this (and perhaps 
check for the other common PHP caching programs) if used in place of MMcache. 
At present it merely reports MMcache is not being used, which seems to a user, 
to be an error.
Comment 1 Antoine "hashar" Musso (WMF) 2005-01-14 06:49:56 UTC
http://eaccelerator.sourceforge.net/
Comment 2 Brion Vibber 2005-01-14 06:53:30 UTC
MediaWiki itself doesn't know or care about the opcode caching solution used on the 
PHP installation.

There is a somewhat experimental option to use Turck MMCache's data-caching 
functions (independently of whether you're caching compiled PHP bytecode), which 
of course only works if those functions are present.
Comment 3 PS 2005-01-14 10:32:43 UTC
These same object caching functions are still present in eAccelerator (which is basically 
a bugfix version of MMcache), but are not recognised by mediawiki.  Reporting of it 
as "absent" on the install page doesnt make clear what the implications of the "absence" 
are.
Comment 4 Brion Vibber 2005-01-14 10:33:42 UTC
Would you mind providing a patch which corrects the detection?
Comment 5 PS 2005-01-14 10:47:11 UTC
I'd do so if I was able, but I lack the ability.  As best I understand it, the few places 
mediawiki looks for the presence of mmcache functions, it should also look for the 
equivalent eaccelerator functions instead, thats all.

From then on, as I understand it, they both use identical names and structures, bar the 
global replace of "mmcache..." --> "eaccelerator..." wherever it occurs (both in variable 
names and (presumably) function names).
Comment 6 Brion Vibber 2005-01-14 10:48:17 UTC
Yes, the function names being different would explain why it doesn't work.
Comment 7 Jamie Bliss 2005-01-16 20:12:42 UTC
I was able to do this in 1.4beta4 (using a local wiki). There are two ways to do this: the full change and the hack. 
The full change maintains support for Turck MMCache, and integrates it into the installer. The hack just gets it to 
work.

For the hack, open up /includes/ObjectCache.php (relative to the install dir), and find the TurckBagOStuff class (line 
418 in mine). In the class, replace the Turck API calls (mmcache_*) with eAccelerator calls (eaccelerator_*). Save it. 
Then go into /LocalSettings.php and override the setting for $wgUseTurckShm (line 129). Either change the function 
name, or just set it to true at the bottom.

For the full change (which is probably excessive), I created an eAccelBagOStuff class. This required changes to 
numerous files. This includes ObjectCache.php, Setup.php, and config/index.php. If patches are not posted for this yet, 
they will be soon.
Comment 8 Jamie Bliss 2005-01-16 20:14:38 UTC
Created attachment 206 [details]
A patch to includes/ObjectCache.php to add the eAccelBagOStuff class.

This is one of the patches for the full change method mentioned in my previous
comment.
Comment 9 Jamie Bliss 2005-01-16 20:18:40 UTC
Created attachment 207 [details]
A patch to includes/Setup.php to use the eAccelBagOStuff class.

This is one of the patches for the full change method mentioned in my previous
comment.
Comment 10 Jamie Bliss 2005-01-16 20:22:55 UTC
Created attachment 208 [details]
A patch to config/index.php to use the eAccelBagOStuff class.

This is one of the patches for the full change method mentioned in my previous
comment.

It should be noted that this patch changes both the LocalSettings.php template
and index.php itself. Especially not that it adds the $wgUseEAccelShm variable
to LocalSettings.php.
Comment 11 Antoine "hashar" Musso (WMF) 2005-01-19 13:21:17 UTC
patch pending.
Comment 12 Jamie Bliss 2005-02-23 22:29:02 UTC
Created attachment 301 [details]
Patch for config/index.php, CVS version 1.93

This is based on version 1.93 of the file.
Comment 13 Jamie Bliss 2005-02-23 22:30:18 UTC
Created attachment 302 [details]
Patch for includes/DefaultSettings.php, CVS version 1.249
Comment 14 Jamie Bliss 2005-02-23 22:31:29 UTC
Created attachment 303 [details]
Patch for includes/ObjectCache.php, CVS version 1.15
Comment 15 Jamie Bliss 2005-02-23 22:32:13 UTC
Created attachment 304 [details]
Patch for includes/Setup.php, CVS version 1.117
Comment 16 Jamie Bliss 2005-02-23 22:35:21 UTC
Posted another batch of patches, this time for CVS. The file version is noted
with the patch.
Comment 17 Jamie Bliss 2005-03-02 01:22:52 UTC
Created attachment 320 [details]
Patch for includes/Setup.php, CVS version 1.117

Fixes a bug in the previous patch relating to the initialization of the
properties of $conf.
Comment 18 Jamie Bliss 2005-03-02 01:31:42 UTC
Created attachment 321 [details]
Patch for config/index.php, CVS version 1.93

The previous 'fix' was for the wrong file.
Comment 19 Brion Vibber 2005-05-04 07:01:19 UTC
Since this is marked as fixed-in-cvs and we're starting the 1.5 beta cycle, resolving as FIXED.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links