Last modified: 2008-03-12 00:21:05 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
Bug 13273 - nbsp before colons on fr
nbsp before colons on fr
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Parser (Other open bugs)
unspecified
All All
: Normal enhancement (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2008-03-06 13:48 UTC by italvet
Modified: 2008-03-12 00:21 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description italvet 2008-03-06 13:48:07 UTC
hello, curently the categories displays like this on fr

 Catégories: Administration Wikipédia | Requête sur Wikipédia

but in french typographic rules, there is a (non-breaking) space between a colon a it's preceeding word

 Catégories : Administration Wikipédia | Requête sur Wikipédia

Maybe it could be possible to append it on the system message, but it looks a dirty hack™ to me (and the software should trim it anyhow), isn't it more relavant to update the french language class ? 

Kind regards.
Comment 1 Raimond Spekking 2008-03-06 14:37:24 UTC
The colons for "Categories" and "Hidden categories" are hardcoded in Skin::getCategoryLinks() :-(

A change is easy but would break localizations done per project.

Comment 2 Huji 2008-03-06 17:24:03 UTC
Then the change should also include addition of the colons in the related messages on all message files. DE and others can then be updated to have the required space (I guess french may have its own restrictions). 
Comment 3 Aryeh Gregor (not reading bugmail, please e-mail directly) 2008-03-06 18:01:33 UTC
Fixed in r31627 (and r31630 for hidden-categories, thanks to Raymond for pointing out that omission).  I changed the message name from pagecategories to page-categories, but left hidden-categories alone.  I also fixed the French translation so that the space before the colon actually worked: you could have just used   all along if you liked, which would not have gotten noticed as trailing whitespace.

This is not something that can be effectively handled by the language classes, or should be.  They don't know how a colon is meant to be used.  Punctuation should never be hardcoded in any case, so this should have been fixed regardless.
Comment 4 Aryeh Gregor (not reading bugmail, please e-mail directly) 2008-03-06 18:35:45 UTC
I'm backing out this fix; it made the colon and space be part of the link.  Will check in a new one shortly.
Comment 5 Aryeh Gregor (not reading bugmail, please e-mail directly) 2008-03-06 18:54:47 UTC
Fixed a different way in r31636, using a new [[MediaWiki:Colon-separator]] message.
Comment 6 italvet 2008-03-11 17:20:07 UTC
Could it be possible to do the same thing for the autocomment in history lines ?

 (actu) (diff) 4 mars 2008 à 13:56 IP 84.5 (Discuter | Contributions | Bloquer) m (21 159 octets) (→« Voir l’historique »: guillemets, merci) (défaire)

which become 

 (actu) (diff) 4 mars 2008 à 13:56 IP 84.5 (Discuter | Contributions | Bloquer) m (21 159 octets) (→« Voir l’historique » : guillemets, merci) (défaire)

Thanks.
Comment 7 Aryeh Gregor (not reading bugmail, please e-mail directly) 2008-03-11 17:59:15 UTC
Fixed in r31805.  If you find any more instances, for the sake of tidiness, please open a new bug instead of re-opening this bug.  You can feel free to CC me on the new bug.
Comment 8 italvet 2008-03-11 21:59:48 UTC
i changed the title of this bug to "nbsp before colons on fr" for this purpose. Is it ok or should i submit several bugs anyway ?
Comment 9 Aryeh Gregor (not reading bugmail, please e-mail directly) 2008-03-12 00:21:05 UTC
The convention is one bug filed per issue, and only reopened if the fix was wrong.  This stops the same bug from being noted 10 different times in release-notes, etc.  If a certain type of bug occurs repeatedly, we open up a tracking bug and mark every instance of it as blocking the tracker (see bug 2007 for a tracker for all the trackers), but this doesn't warrant that.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links