Last modified: 2008-03-16 09:29:31 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
Bug 13269 - Introduce MediaWiki:Uploadfooter message
Introduce MediaWiki:Uploadfooter message
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Interface (Other open bugs)
unspecified
All All
: Normal enhancement (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2008-03-06 10:39 UTC by brianna.laugher
Modified: 2008-03-16 09:29 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description brianna.laugher 2008-03-06 10:39:29 UTC
Hello,

We (Commons) would like to have some text on the upload form that is hidden by default by CSS. (help information.) 

If we include it in MediaWiki:Uploadtext, then for browsers that don't respect "display:none", it will be too overloaded. Therefore we would like Uploadfooter to appear last on the form, below the "Upload file" button. That way if browsers don't respect that it is hidden, it is still quite usable.

The default text should be blank.

thank you.
Comment 1 Alexandre Emsenhuber [IAlex] 2008-03-10 20:33:23 UTC
Fixed in r31761.
Comment 2 brianna.laugher 2008-03-13 09:06:27 UTC
Thankyou Alex, but could it please be more standard... like

 $wgOut->addHTML( '<div id="uploadfooter">' );
 $wgOut->addWikiText???( wfMsg???( 'uploadfooter' ) );
 $wgOut->addHTML( "</div>\n" );

instead of 

 $uploadfooter = wfMsgNoTrans( 'uploadfooter' );
 if( $uploadfooter != '-' && !wfEmptyMsg( 'uploadfooter', $uploadfooter ) ){
       $wgOut->addWikiText( $uploadfooter );
  }

It should be translateable, so I'm pretty sure wfMsgNoTrans is wrong. And it should be able to contain 
HTML.

thankyou.
Comment 3 Niklas Laxström 2008-03-13 09:14:16 UTC
It is translatable, wfMsgNoTrans doesn't mean what you think. Also, we don't add new messages that can contain HTML.

But there is no class or id around it, which might be something that should be fixed.
Comment 4 brianna.laugher 2008-03-13 09:20:16 UTC
(In reply to comment #3)
> It is translatable, wfMsgNoTrans doesn't mean what you think. Also, we don't
> add new messages that can contain HTML.

Does <div> count as HTML? Well, obviously, but I suppose, does it count as wikitext? Because that's actually what I want to use.
 
> But there is no class or id around it, which might be something that should be
> fixed.

And also, please remove the checking about if the message is defined. If the message is not defined, it should just end up as an empty div.
Comment 5 Lupo 2008-03-16 08:45:21 UTC
In the current implementation, transclusions and embedded HTML (<span>s, or <div>s) do work. Just redirects don't, but that can be worked around using a transclusion.

I think the only fixes needed here would be to wrap the message in an identifying <div id="wpUploadfooter"> (or a similar ID), and is the checking for empty or dash really needed?
Comment 6 Niklas Laxström 2008-03-16 09:29:31 UTC
(In reply to comment #5)
> I think the only fixes needed here would be to wrap the message in an
> identifying <div id="wpUploadfooter"> (or a similar ID), and is the checking
> for empty or dash really needed?

Yes. Added id in r32033.


Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links