Last modified: 2008-10-28 00:09:04 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
Bug 13262 - New Talk Page Option
New Talk Page Option
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
InputBox (Other open bugs)
unspecified
All All
: Normal enhancement with 1 vote (vote)
: ---
Assigned To: Trevor Parscal
: patch, patch-need-review
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2008-03-06 03:55 UTC by Tyler Romeo
Modified: 2008-10-28 00:09 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
A patch for the Inputbox extension, to allow the new preload title option (11.65 KB, patch)
2008-03-06 05:17 UTC, X!
Details
Patch against trunk (3.22 KB, patch)
2008-03-06 06:31 UTC, Raimond Spekking
Details
Updated version that parses correctly (2.93 KB, patch)
2008-04-07 22:54 UTC, Brion Vibber
Details

Description Tyler Romeo 2008-03-06 03:55:45 UTC
Currently, the inputbox extension has an option where if you type a page in the box, it makes a new section on the page and brings up the edit box. However, it would be useful if instead, a user enters a topic title into the box, and a new section with that title is created on the page the box is on. For instance, if this:

<inputbox>
type=newsection
</inputbox>

was placed on [[Talk:Main Page]] and a user typed "Hello World" in the box and pressed the button, the edit page for a new section on Talk:Main Page would come up, with "Hello World" as the preloaded title. I suggest this idea as a spin-off of the new "preloadtitle" parameter implemented in the index.php file, allowing the title of a section to be preloaded.
Comment 1 X! 2008-03-06 05:17:01 UTC
Created attachment 4698 [details]
A patch for the Inputbox extension, to allow the new preload title option

This is my first patch, so please tell me if there are any errors. It works on my computer.
Comment 2 Raimond Spekking 2008-03-06 06:31:40 UTC
Created attachment 4699 [details]
Patch against trunk

I have created a unified diff against trunk. Please check it. I was a bit complicated because your editor changed every tab into spaces. But we use tab indention in all source codes.
Comment 3 Aryeh Gregor (not reading bugmail, please e-mail directly) 2008-03-27 00:02:07 UTC
Soxred, I don't think I'm reviewing this anytime soon.  I've never looked at or even really used Inputbox and don't have it installed, plus I have too many others commits I'm supposed to be reviewing.
Comment 4 Brion Vibber 2008-04-07 22:54:09 UTC
Created attachment 4794 [details]
Updated version that parses correctly

Version of previous patch fixing a PHP parse error (HEREDOC string end needs to be at line start, not after whitespace) and a patching error (a changed line that's already in trunk).

I'm not really sure what's going on here; the example usage in the initial comment does not appear to work.

Can you clarify what this patch is supposed to do?

Code in general looks ok for inputbox... Not too fond of the naming for 'getCreateForm2()', can this be renamed or merged with the other function?
Comment 5 X! 2008-04-07 23:09:52 UTC
Example:

<inputbox>
type=preloadtitle
page=User talk:Soxred93
default=Post a comment here!
buttonlabel=Post a comment, with the section title in the box!
</inputbox>
Comment 6 Brion Vibber 2008-04-08 23:15:49 UTC
Ok, I think I've got some vague idea what this means then. :)

I strongly recommend not using 'preloadtitle' as the type name here, as it's not very understandable. The originally-suggested 'newsection' would probably be cleaner; or perhaps simply 'section'.

However, there's already a 'comment' type, which confuses matters; this still requests a page title as the input, though.

Another problem is that the new parameters are not properly initialized; some general cleanup is needed.
Comment 7 Martin 2008-08-14 17:24:47 UTC
Has there been any further progress with this request? I came to request something similar.
Comment 8 Tyler Romeo 2008-08-16 03:22:33 UTC
The current patch looks good. Not sure exactly how up-to-date it is, but I'm sure a little improvement and possibly bug-fixing could make it good. Not sure exactly what to do next though.
Comment 9 X! 2008-08-16 21:02:35 UTC
Right now, just some better names. 
Comment 10 X! 2008-10-28 00:09:04 UTC
Fixed in r42703

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links