Last modified: 2010-05-15 16:03:29 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
Bug 13253 - <noinclude>, <includeonly> and <onlyinclude> in ALL CAPS result in errors now
<noinclude>, <includeonly> and <onlyinclude> in ALL CAPS result in errors now
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
General/Unknown (Other open bugs)
1.13.x
All All
: Normal normal with 1 vote (vote)
: ---
Assigned To: Tim Starling
http://de.wikipedia.org/w/index.php?t...
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2008-03-05 00:31 UTC by bdk
Modified: 2010-05-15 16:03 UTC (History)
0 users

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description bdk 2008-03-05 00:31:14 UTC
1) Please add e.g. <NOINCLUDE>foo</NOINCLUDE> or simply <NOINCLUDE> (yes, ALL CAPS instead of lower case) on any random page and try to safe. This only results in the following error, also on preview (it's not possible to safe the change):

Invalid call hook noinclude
Backtrace:
#0 /usr/local/apache/common-local/php-1.5/includes/Preprocessor_DOM.php(960): Parser->extensionSubstitution(Array, Object(PPFrame_DOM))
#1 /usr/local/apache/common-local/php-1.5/includes/Parser.php(2641): PPFrame_DOM->expand(Object(PPNode_DOM), 0)
#2 /usr/local/apache/common-local/php-1.5/includes/Parser.php(941): Parser->replaceVariables('<NOINCLUDE>??')
#3 /usr/local/apache/common-local/php-1.5/includes/Parser.php(311): Parser->internalParse('<NOINCLUDE>??')
#4 /usr/local/apache/common-local/php-1.5/includes/EditPage.php(1548): Parser->parse('<NOINCLUDE>??', Object(Title), Object(ParserOptions))
#5 /usr/local/apache/common-local/php-1.5/includes/EditPage.php(1157): EditPage->getPreviewText()
#6 /usr/local/apache/common-local/php-1.5/includes/EditPage.php(474): EditPage->showEditForm()
#7 /usr/local/apache/common-local/php-1.5/includes/EditPage.php(342): EditPage->edit()
#8 /usr/local/apache/common-local/php-1.5/includes/Wiki.php(445): EditPage->submit()
#9 /usr/local/apache/common-local/php-1.5/includes/Wiki.php(48): MediaWiki->performAction(Object(OutputPage), Object(Article), Object(Title), Object(User), Object(WebRequest))
#10 /usr/local/apache/common-local/php-1.5/index.php(90): MediaWiki->initialize(Object(Title), Object(OutputPage), Object(User), Object(WebRequest))
#11 /usr/local/apache/common-local/live-1.5/index.php(3): require('/usr/local/apac...')
#12 {main}

This is generally the same for <INCLUDEONLY> and <ONLYINCLUDE>.

2) This problem is pretty new as you can see from the following case:
Please first have a look at this diff 
http://de.wikipedia.org/w/index.php?title=Wikipedia:Verbesserungsvorschl%C3%A4ge/Feature-Requests/Archiv/2007&diff=43297074&oldid=42760361 
and then click on the previous revision (you can't access it directly atm, only by adding &action=edit; preview fails too).
The relevant edit by [[de:User:W!B:]] (who originally added <NOINCLUDE> to the page [[de:Wikipedia:Verbesserungsvorschläge/Feature-Requests]]) dates back to 2007-01-08 - more than one year ago, see
http://de.wikipedia.org/w/index.php?title=Wikipedia:Verbesserungsvorschl%C3%A4ge/Feature-Requests&oldid=26123468 (also not accessible atm).
Since then the page has been edited more than 400 times. All the versions between January 2007 and February 20, 2008 are currently not accessible. 
On 2008-02-20 a bot successfully archived the section in question, see http://de.wikipedia.org/w/index.php?title=Wikipedia:Verbesserungsvorschläge/Feature-Requests&diff=42760320&oldid=42759625
The error was first noticed on 2008-03-04 on de.wikipedia.

I assume that there are dozens of pages or old revisions on the wikis that are affected by this issue. 

Note: The expected behaviour for all caps forms of <noinclude> etc. is that they get ignored.
Comment 1 Brion Vibber 2008-03-05 00:46:12 UTC
Can confirm the lovely fatal exception...

Assigning to Tim for investigation.
Comment 2 Tim Starling 2008-03-05 01:19:02 UTC
Fixed in r31564.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links