Last modified: 2014-11-18 18:07:07 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T15133, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 13133 - Mark edits reverted by a rollback as patrolled
Mark edits reverted by a rollback as patrolled
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
General/Unknown (Other open bugs)
unspecified
All All
: Normal enhancement with 1 vote (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2008-02-24 15:42 UTC by Tisza Gergő
Modified: 2014-11-18 18:07 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Tisza Gergő 2008-02-24 15:42:36 UTC
If an edit has been rolled back by an administrator (or whoever has the right), there is no point in patrolling it; such edits should be automatically marked as patrolled (with a log text different from the standard one, to avoid misunderstandings).
Comment 1 Aaron Schulz 2008-02-24 20:49:19 UTC
The only thing is that the admin doesn't necessarily know what revision he is reverting to.
Comment 2 Tisza Gergő 2008-02-24 21:41:18 UTC
That revision shouldn't be autopatrolled; the revisions that have been undone by the rollback should. Whatever they contained was removed from the article; there is no point in checking them anymore.
Comment 3 Huji 2008-02-25 10:18:56 UTC
(In reply to comment #0)
> If an edit has been rolled back by an administrator (or whoever has the right),
> there is no point in patrolling it; such edits should be automatically marked
> as patrolled (with a log text different from the standard one, to avoid
> misunderstandings).
> 

Actually, if this is going to be implemented, "all" revisions that were reverted through a rollback should be marked as patrolled.

Actually, the current bahaviour of MediaWiki is that it marks the reverting edit as patrolled, not the reverted edits. Article.php lines 2364-2367:

		if ( $wgUseRCPatrol ) {
			# Mark all reverted edits as patrolled
			$set['rc_patrolled'] = 1;
		}
Comment 4 Tisza Gergő 2008-02-25 20:48:34 UTC
On second thought, patrol and rollback might be separate rights on some wikis. So reverted revisions should be marked as patrolled only if the rollback-user has patrol right; and the reverting edit should be marked patrolled only if the user has autopatrol right.

(Marking the reverting edit as patrolled doesn't seem too dangerous; whether the user reverts to a vandalized revision won't show in the diff, so anyone manually patrolling the reverting edit wouldn't notice it either. Instead, it would be caught when patrolling the edit that came before the reverted ones.)
Comment 5 Aaron Schulz 2008-03-24 19:46:48 UTC
This was added a while ago.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links