Last modified: 2008-10-17 22:20:33 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
Bug 1306 - Suppress the "email this user" link in the toolbox if said user has opted not to/can't receive emails
Suppress the "email this user" link in the toolbox if said user has opted not...
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Special pages (Other open bugs)
unspecified
All All
: Normal enhancement with 4 votes (vote)
: ---
Assigned To: Emufarmers
: patch, patch-need-review
: 4516 (view as bug list)
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2005-01-10 22:15 UTC by T. Gries
Modified: 2008-10-17 22:20 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
Completely hides the emailuser link if it wouldn't work (1.41 KB, patch)
2008-10-08 21:31 UTC, Emufarmers
Details
Revised version (1.60 KB, patch)
2008-10-10 00:47 UTC, Emufarmers
Details

Description T. Gries 2005-01-10 22:15:35 UTC
If someone wants to send an e-mail to a user, he clicks onto that link in the
navi-bar.

The Wikis are currently slow and then, after a while, you see probably something
like "This user has not specified a valid e-mail address, or has chosen not to
receive e-mail from other users."

I propose to either 

a) suppress the display of the link "e-mail this user" if this user has no email
stored or has disabled to receive mails 

or to 

b) indicate "feature unavailable" by another kind of indication.

Couldn't this be lower the traffic a little bit ? In any sense, I often was
suprised, that the link was shown, even when I could not send an e-mail to a
user, because he hasn't indicated an address.

Other related bugzilla, not depending or blocking:

1. http://bugzilla.wikipedia.org/show_bug.cgi?id=1226 (negate "disable mail"
option box logic GUI)
2. http://bugzilla.wikipedia.org/show_bug.cgi?id=1133 (send optionally a "CC"
back to sender of EmailUser)
Comment 1 T. Gries 2005-01-10 22:27:11 UTC
Developers: 

how do you think about this change in the user interface
- dropping the display "e-mail this user", if emailing is not possible to that user

Wouldn't it be better to show the link, but to indicate (with "grey" color ?),
that it is not possible to mail ?

(In reply to comment #0)

> If someone wants to send an e-mail to a user, he clicks onto that link in the
> navi-bar.
> 
> The Wikis are currently slow and then, after a while, you see probably something
> like "This user has not specified a valid e-mail address, or has chosen not to
> receive e-mail from other users."
> 
> I propose to either 
> 
> a) suppress the display of the link "e-mail this user" if this user has no email
> stored or has disabled to receive mails 
> 
> or to 
> 
> b) indicate "feature unavailable" by another kind of indication.
> 
> Couldn't this be lower the traffic a little bit ? In any sense, I often was
> suprised, that the link was shown, even when I could not send an e-mail to a
> user, because he hasn't indicated an address.
> 
> Other related bugzilla, not depending or blocking:
> 
> 1. http://bugzilla.wikipedia.org/show_bug.cgi?id=1226 (negate "disable mail"
> option box logic GUI)
> 2. http://bugzilla.wikipedia.org/show_bug.cgi?id=1133 (send optionally a "CC"
> back to sender of EmailUser)

Comment 2 T. Gries 2005-01-24 09:32:40 UTC
(In reply to comment #1)
> Wouldn't it be better to show the link, but to indicate (with "grey" color ?),
> that it is not possible to mail ? If someone wants to send an e-mail to a
user, he clicks onto that link in the
> navi-bar.

> > I propose to either 
> > 
> > a) suppress the display of the link "e-mail this user" if this user has no email
> > stored or has disabled to receive mails 

ADDED:
If the visiting user (potential sender) is not logged-in or has no email stored,
than the link text must also not be shown, as is proposed by older see
http://bugzilla.wikipedia.org/show_bug.cgi?id=356 (added below).

> > 
> > or to 
> > 
> > b) indicate "feature unavailable" by another kind of indication.
> > 
> > Couldn't this be lower the traffic a little bit ? In any sense, I often was
> > suprised, that the link was shown, even when I could not send an e-mail to a
> > user, because he hasn't indicated an address.
> > 
> > Other related bugzilla, not depending or blocking:
> > 

1. http://bugzilla.wikipedia.org/show_bug.cgi?id=1226 (negate "disable mail"
option box logic GUI)
2. http://bugzilla.wikipedia.org/show_bug.cgi?id=1133 (send optionally a "CC"
back to sender of EmailUser)
3. http://bugzilla.wikipedia.org/show_bug.cgi?id=356  ("E-mail this user" errors
not labeled well) +++THIS ONE ADDED TO THE LIST
Comment 3 Toby Bartels 2005-01-24 19:40:40 UTC
Tom Gries wrote in Additional Comment #1:

>Wouldn't it be better to show the link, but to indicate (with "grey" color ?),
>that it is not possible to mail ?

It would be better to show the ''text'', but it should not be a ''link''.
Even a red link would serve no purpose, so why tempt people to click it?
(Although I think that whether to show the text is less important
than to NOT show the link.)

It's worth noting that this link does serve a purpose currently:
It allows one to see, at a glance, that a user with no user page exists.
That is, suppose that [[User:Foo]] exists but has no user page,
while nobody has ever signed up as [[User:Bar]] to begin with.
If you go to their user pages, there is little sign of this difference,
and you might be led to think that [[User:Foo]] doesn't exist either.
But in fact, there will be an "E-mail this user" link for [[User:Foo]],
while no such link exists for [[User:Bar]].

This is not enough reason to avoid the enhancement of course.
There are two remedies: replacing the link with (grey) text,
and the "User contributions" link, which has the same behaviour.
But it's something to be aware of.


-- [[w:en:User:Toby Bartels]]
Comment 4 T. Gries 2006-01-07 18:56:46 UTC
*** Bug 4516 has been marked as a duplicate of this bug. ***
Comment 5 Rob Church 2006-01-07 19:46:03 UTC
You'd still have to check to see whether said user opts to/can receive email, so
performance-wise, it's not a massive difference. From the user interface point
of view, however, it makes sense not to show the text, linked or not, if the
feature's not available.
Comment 6 Brion Vibber 2006-01-07 19:50:56 UTC
Just a note: if implementing this, don't forget to touch & purge the user page when the user's 
prefs or mail confirmation state changes.
Comment 7 lɛʁi לערי ריינהארט 2006-01-31 12:23:14 UTC
Hallo!

In my opinion the user interface for user A regarding "E-mail this user" at user
B's user and user talk page should depend on
a) has user A specified [[MediaWiki:Allowemail]] ?
b) has user A performed [[MediaWiki:Emailconfirmlink]] ?
c) has user B specified [[MediaWiki:Allowemail]] ?
d) has user B performed [[MediaWiki:Emailconfirmlink]] ?

The question is what actions should be performed / what links should be
generated. A grey link will not guide users. Probably displaying the specific
details with links to [[special:Preferences]], [[special:Confirmemail]] ?)
together with "&returnto=foo" would be a better choice.

best regards reinhardt [[user:gangleri]]
Comment 8 lɛʁi לערי ריינהארט 2006-01-31 12:26:41 UTC
(In reply to comment #7)
> ... d) has user B performed [[MediaWiki:Emailconfirmlink]] ?

implies
e) has user A specified an email address ?
f) has user B specified an email address ?
Comment 9 Emufarmers 2008-10-08 21:31:25 UTC
Created attachment 5404 [details]
Completely hides the emailuser link if it wouldn't work

It seems to make the most sense to just hide the link if it won't work, rather than making it plaintext.
Comment 10 Brion Vibber 2008-10-09 20:36:29 UTC
I think I'd recommend moving the $wgEnableUserEmail check into User::canSendEmail() to simplify things in general. The $wgUser->isLoggedIn() checks is also redundant; an anonymous user won't pass that test. :)

The user page cache invalidation in User::saveSettings will do the job for when someone enables/disables the email option... and it should also do the job for other stuff. Excellent. :D
Comment 11 T. Gries 2008-10-09 20:59:44 UTC
(In reply to comment #10)
> Excellent. :D
Even when considering that I proposed this ?
Comment 12 Emufarmers 2008-10-10 00:47:34 UTC
Created attachment 5413 [details]
Revised version

(In reply to comment #10)
> The user page cache invalidation in User::saveSettings will do the job for when
> someone enables/disables the email option... and it should also do the job for
> other stuff. Excellent. :D
> 
I had a small progasm when I got the cache invalidation right.
Comment 13 Brion Vibber 2008-10-17 22:20:33 UTC
/me hugs Tom Gries :)

Emufarmers -- applied in r42179 with one-char fix (missing $ on one of the var checks).

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links