Last modified: 2012-11-14 12:22:51 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
Bug 13010 - Invalid language codes should fallback to default wiki language not English
Invalid language codes should fallback to default wiki language not English
Status: RESOLVED WORKSFORME
Product: MediaWiki
Classification: Unclassified
Internationalization (Other open bugs)
unspecified
All All
: Lowest enhancement with 1 vote (vote)
: ---
Assigned To: Nobody - You can work on this!
http://fr.wikipedia.org/wiki/Special:...
: patch, patch-need-review
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2008-02-13 14:53 UTC by Meno25
Modified: 2012-11-14 12:22 UTC (History)
8 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
Fixes the mentioned bug (1.59 KB, patch)
2008-02-14 10:46 UTC, Huji
Details
other version (1.05 KB, patch)
2008-02-14 11:42 UTC, Alexandre Emsenhuber [IAlex]
Details

Description Meno25 2008-02-13 14:53:08 UTC
Current behavior:

When trying to view a page by entering an invalid language code in the "uselang=" parameter, the wiki fallbacks to English.

Desired behavior:

When trying to view a page by entering an invalid language code in the "uselang=" parameter, the wiki fallbacks to the default language set for the wiki.

Example to illustrate (see URL):

In the French (fr) Wikipedia, when trying to view recent changes by entering abc as a language code (there is no language whose code is abc), the wiki fallbacks to English. In fact it should fallback to French (default language in wiki).
Comment 1 Huji 2008-02-14 10:46:10 UTC
Created attachment 4652 [details]
Fixes the mentioned bug

This patch allows trying to fall back to the content language, before an effort to falling back to 'en'. I'm not applying it, because I both need it to be reviewed, and think acceptance of some more experienced developers is needed about such a change in the behaviour of wiki software.
Comment 2 Huji 2008-02-14 10:51:52 UTC
Marking for review. Also, I want to credit Alexandre Emsenhuber (ialex) for his helping me finding where to fix. :)
Comment 3 Alexandre Emsenhuber [IAlex] 2008-02-14 11:42:34 UTC
Created attachment 4653 [details]
other version

other patch to fix that bug, does not throw an exception when the content language code is invalid.
Comment 4 Victor Vasiliev 2008-02-17 15:37:21 UTC
Fixed in r31022
Comment 5 Huji 2008-02-18 10:24:59 UTC
VasillievVV,

The reason we didn't apply the second patch was that it didn't include the error logging features which were available in the first patch, although it was more straightforward. I didn't get the time to make a third patch which combines the two.

I guess I'm going to add the debugging features right to the code, if you don't do it sooner than me.
Comment 7 Niklas Laxström 2008-07-11 19:23:53 UTC
I see no good motivation for this change, and the commons would need a alternative way for their hack for this be changed.
Comment 8 Waldir 2011-08-04 11:11:25 UTC
I just checked with Krinkle; the patch had nothing wrong -- Commons is the one using uselang in a nonstandard way. The best approach would be to implement a different setup for the Special:Upload customization, but since the new uploader is coming around, we just need to wait until the current one is superseded and then this patch can be safely applied. I'm marking the bug as "fix later" rather than "wontfix".
Comment 9 Diederik van Liere 2011-11-29 22:34:22 UTC
Has LATER arrived?
Comment 10 Waldir 2011-11-30 10:04:40 UTC
(In reply to comment #9)
> Has LATER arrived?

I suppose... is the new uploader the default for everyone in Commons now? I know I got it last time I uploaded a file.
Comment 11 Nemo 2012-03-02 08:42:17 UTC
(In reply to comment #10)
> (In reply to comment #9)
> > Has LATER arrived?
> 
> I suppose... is the new uploader the default for everyone in Commons now? I
> know I got it last time I uploaded a file.

This doesn't seem enough for the old system to be dropped. There's still no way to get the same customisation on wiki.
Comment 12 Nemo 2012-11-14 12:22:51 UTC
Switching from LATER to the second most relevant resolution for fear of information loss. http://article.gmane.org/gmane.science.linguistics.wikipedia.technical/65116

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links