Last modified: 2010-05-15 15:33:50 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
Bug 1300 - External links in captions break images.
External links in captions break images.
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Parser (Other open bugs)
1.4.x
All All
: Normal normal with 1 vote (vote)
: ---
Assigned To: Ævar Arnfjörð Bjarmason
http://en.wikipedia.org/wiki/User:Gre...
: need-parsertest, parser
: 1905 (view as bug list)
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2005-01-10 08:35 UTC by grendelkhan
Modified: 2010-05-15 15:33 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
patch for CVS (679 bytes, patch)
2005-04-18 20:21 UTC, Michael Keppler
Details

Description grendelkhan 2005-01-10 08:35:28 UTC
See linked page at
[[en:User:Grendelkhan/Scratch#External_links_in_captions_break_images]].

The following displays an image with a broken caption, and a spurious closing
bracket afterwards:

[[Image:Wiki.png|left|thumb|From [http://wikipedia.org Wikipedia]]]

Any space between the first and other two closing brackets causes the image not
to be displayed at all.

[[Image:Wiki.png|left|thumb|From [http://wikipedia.org Wikipedia], the free
encyclopedia.]]

This is a problem for articles like [[en:History of Arda]], which need to
provide credit and link-backs for the images they use. There is currently no way
to display external links in image captions unless bare links are used, or the
DIVs are manually written in. (The following works, for instance.)

[[Image:Wiki.png|left|thumb|From http://wikipedia.org]]
Comment 1 Ævar Arnfjörð Bjarmason 2005-04-12 06:03:44 UTC
Actually it was only external links that closed immitiately before the image
link itself closed, like:

* [[Image:Foo.png|thumb|[http://example.com]]] as opposed to

* [[Image:Foo.png|thumb|[http://example.com].]] which worked.

I've fixed the issue in HEAD and REL1_4, thanks for the report.
Comment 2 Michael Keppler 2005-04-18 20:19:14 UTC
The bugfix is slightly buggy. The regexp in the parser which checks for the
existence of "]]]" (tripel closing bracket) needs an additional regexp modifier
"s" to also consume over newlines with the ".*" regexp part.

This will also fix bug #1905.
Comment 3 Michael Keppler 2005-04-18 20:21:57 UTC
Created attachment 428 [details]
patch for CVS
Comment 4 Michael Keppler 2005-04-18 20:23:49 UTC
*** Bug 1905 has been marked as a duplicate of this bug. ***
Comment 5 Ævar Arnfjörð Bjarmason 2005-04-19 17:20:42 UTC
Applied it to REL1_4 and HEAD, thanks.
Comment 6 Ævar Arnfjörð Bjarmason 2005-04-19 17:22:35 UTC
Adding wikibugs-l@wikipedia.org as a CC (it was removed)

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links