Last modified: 2008-08-15 01:55:31 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T14976, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 12976 - WebResponse->setcookie() should handle prefixes
WebResponse->setcookie() should handle prefixes
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
General/Unknown (Other open bugs)
1.12.x
All All
: Normal enhancement (vote)
: ---
Assigned To: Nobody - You can work on this!
http://svn.wikimedia.org/viewvc/media...
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2008-02-09 04:44 UTC by Edward Z. Yang
Modified: 2008-08-15 01:55 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Edward Z. Yang 2008-02-09 04:44:46 UTC
Except under special cases (such as when the cookie needs to be shared with some other software), all cookies should be prefixed with $wgCookiePrefix (a quick grep indicates that this is indeed the case for all existing code). I propose that WebResponse->setcookie() should automatically handle prefixes. In addition, all of the stray setcookie() calls should be using $wgRequest->response()->setcookie() instead.

Do you think this is a good idea?
Comment 1 Chad H. 2008-08-15 01:55:20 UTC
Done in r39376

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links