Last modified: 2008-08-15 01:55:31 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
Bug 12976 - WebResponse->setcookie() should handle prefixes
WebResponse->setcookie() should handle prefixes
Product: MediaWiki
Classification: Unclassified
General/Unknown (Other open bugs)
All All
: Normal enhancement (vote)
: ---
Assigned To: Nobody - You can work on this!
Depends on:
  Show dependency treegraph
Reported: 2008-02-09 04:44 UTC by Edward Z. Yang
Modified: 2008-08-15 01:55 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Description Edward Z. Yang 2008-02-09 04:44:46 UTC
Except under special cases (such as when the cookie needs to be shared with some other software), all cookies should be prefixed with $wgCookiePrefix (a quick grep indicates that this is indeed the case for all existing code). I propose that WebResponse->setcookie() should automatically handle prefixes. In addition, all of the stray setcookie() calls should be using $wgRequest->response()->setcookie() instead.

Do you think this is a good idea?
Comment 1 Chad H. 2008-08-15 01:55:20 UTC
Done in r39376

Note You need to log in before you can comment on or make changes to this bug.