Last modified: 2011-01-15 12:39:57 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T14968, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 12968 - Render redirect wikilinks in a redirect class for customization via user/site CSS.


Summary:	Render redirect wikilinks in a redirect class for customization via user/site...

Status:	RESOLVED DUPLICATE of bug 166

Product:	MediaWiki
Classification:	Unclassified
Component:	Parser (Other open bugs)
Version:	1.12.x
Hardware:	All All

Importance:	Normal enhancement (vote)
Target Milestone:	---
Assigned To:	Nobody - You can work on this!

URL:
Whiteboard:
Keywords:	parser, patch

Duplicates:	6962 (view as bug list)
Depends on:
Blocks:	css
	Show dependency tree / graph

Reported:	2008-02-08 06:59 UTC by Cobi
Modified:	2011-01-15 12:39 UTC (History)
CC List:	5 users (show)

See Also:
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
Fixes this bug report. (677 bytes, patch) 2008-02-08 06:59 UTC, Cobi	Details
Reworked patch (908 bytes, patch) 2008-02-08 11:19 UTC, Raimond Spekking	Details
Show Obsolete (1) Add an attachment (proposed patch, testcase, etc.)

Description Cobi 2008-02-08 06:59:28 UTC

Created attachment 4633 [details]
Fixes this bug report.

Redirect wikilinks should have a redirect class to allow for customization/highlighting of redirects in user/site CSS.

Obsoletes the highly resource-intensive javascript that does the same thing: http://en.wikipedia.org/wiki/User:Dschwen/highlightredirects.js

Comment 1 Raimond Spekking 2008-02-08 11:19:46 UTC

Created attachment 4634 [details]
Reworked patch

I have optimized the code a bit and renamed the CSS class to 'mw-redirect' to be consistent with the naming conventions for new CSS classes/IDs.

But I wonder if it is intended that this will work only for registered users who have set a threshold > 0 in its preferences?

The function getLinkColour() is called from Linker::makeLinkObj for $threshold > 0 only.

Comment 2 Raimond Spekking 2008-02-12 18:03:36 UTC

On a second thought: applied with r30871. It works for logged in users who have set a threshold > 0 in its preferences. This way no extra database query is necessary.

Comment 3 Aryeh Gregor (not reading bugmail, please e-mail directly) 2008-02-12 19:49:47 UTC

*** Bug 4709 has been marked as a duplicate of this bug. ***

Comment 4 Aryeh Gregor (not reading bugmail, please e-mail directly) 2008-02-12 19:50:02 UTC

*** Bug 6962 has been marked as a duplicate of this bug. ***

Comment 5 Aryeh Gregor (not reading bugmail, please e-mail directly) 2008-02-12 19:59:40 UTC

Improved fix in r30876.  It now works for all users, logged in or not and independent of preferences.

Comment 6 Aryeh Gregor (not reading bugmail, please e-mail directly) 2008-02-19 21:08:18 UTC

(In reply to comment #5)
> Improved fix in r30876.  It now works for all users, logged in or not and
> independent of preferences.

Although, note, currently not in all circumstances -- e.g., category links, or anything else using makeLinkObj() (includes lots of special pages).  Would be nice to improve LinkCache to fetch and store this info as it does article ID's, so that it could be done efficiently there too.  I've left a comment in the code roughly to that effect.

Comment 7 Happy-melon 2011-01-15 12:39:57 UTC

Bug 166 requests full implementation of this feature.

*** This bug has been marked as a duplicate of bug 166 ***

Wikimedia Bugzilla is closed!

Search

Personal tools

Navigation

Links