Last modified: 2008-02-03 19:03:23 UTC
prop=imageinfo has no query-continue to determine the new values of iistart and iiend. For clients it is preferable to have all property generators behave the same way. Therefore prop=imageinfo should return a query-continue similarly to prop=revisions.
Fixed myself in r30432.
(In reply to comment #1) > Fixed myself in r30432. > I don't really see how r30432 fixes this bug.
Sorry, I thought I created a bug for another unrelated imageinfo problem and just clicked the top item in "My bugs"... Apparently wrong.
Created attachment 4610 [details] Proposed not working patch Proposed patch. The problem however is that iistart is apparently evaluated with the boundary excluded, so this patch will skip one item for each iteration. This could be fixed by adding +1 to the continue parameter, but should maybe be changed in the backend?
Created attachment 4611 [details] Updated patch This patch changes the behaviour of the backend LocalFile. I checked and no other functions in the core are affected by this change.
Comment on attachment 4611 [details] Updated patch The normal way of doing is simply to fetch $limit+1 revisions and returning the last one's timestamp as query-continue value. No need to change the backend. Look at any list module (like ApiQueryAllpages) and search for "the one extra".
I know that. Patch #4611 actually does that, and returns a new iistart value. However, getHistory(limit, start, end) will return all items between start and end, excluding the boundaries. One way to solve that is by adding 1 to the query-continue values, but that is imho an ugly solution, since there is no reason why getHistory would not include start and end.
Comment on attachment 4611 [details] Updated patch Ah, I see. I'll look into getting this to work tomorrow evening or, if I won't have time then, on Monday.
Patch applied in r30483.
