Last modified: 2008-06-05 04:16:10 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T14859, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 12859 - $wgRateLimitsExcludedGroups should be replaced by 'noratelimits' right


Summary:	$wgRateLimitsExcludedGroups should be replaced by 'noratelimits' right

Status:	RESOLVED FIXED

Product:	MediaWiki
Classification:	Unclassified
Component:	General/Unknown (Other open bugs)
Version:	1.12.x
Hardware:	All All

Importance:	Normal enhancement (vote)
Target Milestone:	---
Assigned To:	Nobody - You can work on this!

URL:
Whiteboard:
Keywords:	patch, patch-need-review

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2008-02-01 13:52 UTC by Roan Kattouw
Modified:	2008-06-05 04:16 UTC (History)
CC List:	3 users (show)

See Also:
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
Patch that adds the 'noratelimits' right (1.53 KB, patch) 2008-02-01 13:52 UTC, Roan Kattouw	Details
Add an attachment (proposed patch, testcase, etc.)

Description Roan Kattouw 2008-02-01 13:52:19 UTC

Created attachment 4605 [details]
Patch that adds the 'noratelimits' right

I don't really understand why we still have $wgRateLimitsExcludedGroups = array('sysop', 'bureaucrat'); while we could as well have:

$wgGroupPermissions['sysop']['noratelimits'] = true;
$wgGroupPermissions['bureaucrat']['noratelimits'] = true;

Is there some underlying reason I'm missing here, or is it just that no one has thought of this and/or gotten around to implementing this yet?

Comment 1 Chad H. 2008-06-03 14:54:23 UTC

Done in r35794. Input welcome, this being my first commit.

Comment 2 Brion Vibber 2008-06-04 17:33:42 UTC

I seem to recall reverting that one, some issues remaining. :)

Comment 3 Chad H. 2008-06-05 04:16:10 UTC

Fixed in r35908. Got it right this time. ;-)

Kept the old functionality intact, but updated the documentation on it to reflect that it's been deprecated in favor of the new method via $wgGroupPermissions.

Wikimedia Bugzilla is closed!

Search

Personal tools

Navigation

Links