Last modified: 2008-02-02 00:17:58 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T14792, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 12792 - $wgTidyInternal not initialized correctly
$wgTidyInternal not initialized correctly
Status: RESOLVED INVALID
Product: MediaWiki
Classification: Unclassified
General/Unknown (Other open bugs)
1.12.x
PC All
: Normal normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2008-01-25 20:40 UTC by Michael Daly
Modified: 2008-02-02 00:17 UTC (History)
0 users

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Michael Daly 2008-01-25 20:40:48 UTC
In version 1.12, the initialization of $wgTidyInternal in DefaultSettings.php is based on detecting the presence of Tidy.

In all previous PHP5 versions of Mediawiki, this variable has defaulted to false.  With the new version, a Windows version using internal Tidy with PHP5 (the standard for PHP5 binaries for Windows) will default to true.  If the administrator is upgrading from 1.11 or earlier, this automatic enabling of Tidy can cause problems with some page rendering, especially if certain types of templates are used.

To be consistent, $wgTidyInternal should continue to default to false.
Comment 1 Brion Vibber 2008-02-02 00:13:36 UTC
Defaulting the use of internal tidy to true when an internal tidy is present seems like very desirable behavior.

Note that tidy itself would continue to be off by default.
Comment 2 Brion Vibber 2008-02-02 00:17:58 UTC
I've added a note about this to RELEASE-NOTES in r30412

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links