Last modified: 2008-03-02 21:20:33 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
Bug 12723 - Trimmed name for Firefox search plugin
Trimmed name for Firefox search plugin
Product: Wikimedia
Classification: Unclassified
General/Unknown (Other open bugs)
All All
: Normal normal with 2 votes (vote)
: ---
Assigned To: Nobody - You can work on this!
: accessibility, easy
Depends on:
  Show dependency treegraph
Reported: 2008-01-21 12:43 UTC by wooptoo
Modified: 2008-03-02 21:20 UTC (History)
1 user (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

trimmed name triggers the Add item again (6.21 KB, image/png)
2008-01-21 12:43 UTC, wooptoo

Description wooptoo 2008-01-21 12:43:26 UTC
Created attachment 4566 [details]
trimmed name triggers the Add item again

Steps to reproduce:
(Firefox only)

1. go to Wikimedia Commons home page:
2. click on the icon of the search field in Firefox
3. click "Add Wikimedia Commons {English)"
4. click on the icon of the search field again


The search plugin is added with the name "Wikimedia Commons {Engli" instead of the full name.
This also triggers the reappearing of the "Add Wikimedia Commons {English)" item, because the browser thinks it hasn't been added yet.

Proposed solution:

Because the name for Firefox search plugins is limited to 24 characters, Wikimedia could choose to rename the plugin from "Wikimedia Commons {English)" to something like "Wikimedia Commons EN".
Comment 1 wooptoo 2008-01-21 12:50:19 UTC
It seems that Firefox supports plugin names longer than 24 characters.
This is a bug in Wikimedia's :
<ShortName>Wikimedia Commons (Engli</ShortName>
Comment 2 Robert Leverington 2008-01-25 23:32:54 UTC
Due to the OpenSearch 1.1 Draft 3 specification the ShortName tag must contain 16 or fewer characters, therefore this is a bug in two respects -- it exceeds the limit and trims to a weird place. A suggested fix would be to use the language code instead of the language name, to help reduce the length as the title could easily exceed this, and to trim to 16 characters instead, satisfying the specification. Adding a further global configuration variable might help things further - but probably few website owners would care enough so it would largely go unused.
Comment 3 Brion Vibber 2008-02-27 04:57:07 UTC
Switched the description in r31336/r31337 to use the language code, which is more compact. The entire text is now overridable in an 'opensearch-desc' message.

(Note this change won't be live on Wikimedia sites immediately.)
Comment 4 Brion Vibber 2008-03-02 21:20:33 UTC
Updated in r31469 to use the same desc message for the <link> header as well as the final XML. Should resolve issue with Firefox thinking it wasn't the same search plugin due to different name.

Note You need to log in before you can comment on or make changes to this bug.