Last modified: 2014-11-04 22:51:54 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
Bug 12681 - New messages bar should appear above page title, for consistency with other message boxes
New messages bar should appear above page title, for consistency with other m...
Status: REOPENED
Product: MediaWiki
Classification: Unclassified
Interface (Other open bugs)
unspecified
All All
: Low enhancement with 3 votes (vote)
: ---
Assigned To: Nobody - You can work on this!
: design, patch, patch-reviewed
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2008-01-18 22:10 UTC by MZMcBride
Modified: 2014-11-04 22:51 UTC (History)
10 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
Desired effect can happen by applying this patch. (1.25 KB, patch)
2008-01-24 12:40 UTC, Huji
Details
Screenshot of 'United States' from enwiki on a local test wiki (170.53 KB, image/png)
2008-01-25 23:52 UTC, Brion Vibber
Details
Alternative positioning suggestion. (88.61 KB, image/png)
2008-11-25 04:23 UTC, Mark Clements (HappyDog)
Details
Current gerrit patch screenshot on Vector skin (185.93 KB, image/png)
2012-04-09 17:41 UTC, Brion Vibber
Details
Current gerrit patch screenshot on Monobook skin (201.31 KB, image/png)
2012-04-09 17:42 UTC, Brion Vibber
Details

Description MZMcBride 2008-01-18 22:10:22 UTC
Having the new messages bar appear above the page title would make it much more difficult to spoof.
Comment 1 Huji 2008-01-19 08:51:06 UTC
Added a permalink to an example of spoofing new message alert on English Wikipedia (see URL section above).
Comment 2 Huji 2008-01-24 12:40:34 UTC
Created attachment 4574 [details]
Desired effect can happen by applying this patch.

I've added a patch which does what is requested here. Whether this should be applied can be controversial. I'm going to ask some more experienced developers to have a look and comment about it.
Comment 3 Thomas "Tango" Dalton 2008-01-24 13:12:12 UTC
I prefer the other suggestion I've seen for stopping spoofs: include the username in the message. You can't spoof a username without {{CURRENTUSER}} which isn't available on any Wikimedia wikis to my knowledge, and probably isn't used on many others either.
Comment 4 Gurch 2008-01-24 14:29:38 UTC
Wow, people still care about this?

New messages bar spoofing is like rickrolling, only older and even more pointless.
Comment 5 Thomas "Tango" Dalton 2008-01-24 16:43:33 UTC
It is rather annoying...
Comment 6 Aryeh Gregor (not reading bugmail, please e-mail directly) 2008-01-24 19:59:09 UTC
This is pointless, IMO.  The usertalk thing can still easily be spoofed with absolute positioning, unless bug 9526 is fixed.  Adding the username is a much more sensible tactic.
Comment 7 CBM 2008-01-24 20:11:05 UTC
Adding a username is bug 12693
Comment 8 Xaos Flux 2008-01-24 23:26:33 UTC
Not needed.
Comment 9 Aryeh Gregor (not reading bugmail, please e-mail directly) 2008-01-25 00:21:37 UTC
It was pointed out on IRC that every other message box (site notice, AJAX watch, . . .) goes above the header, and that in fact this is the logical place for message boxes (as opposed to being beneath the header and therefore in the same place as article text).  The previous rationale was dubious, but the new point is certainly valid enough to make the change.  Committed in r30136.
Comment 10 Huji 2008-01-25 08:22:32 UTC
Please notice that this change only affects MonoBook skin. Other skins may also need to be updated accordingly.
Comment 11 Brion Vibber 2008-01-25 23:49:48 UTC
Reverted in r30159.

The new location of message bar interferes with lock, geolocation, etc magic templates in use on Wikimedia sites. Hold off on this until there's a system for properly handling those "out of content area" magicks.
Comment 12 Brion Vibber 2008-01-25 23:52:04 UTC
Created attachment 4580 [details]
Screenshot of 'United States' from enwiki on a local test wiki

'Protected page' icon shown overlapping the messages bar.

(Ignore the bad SVG rendering. :)
Comment 13 MZMcBride 2008-06-10 03:50:27 UTC
Presumably, the new messages bar will only be visible for a very short time (until the user checks their messages). Seeing that the sitenotice and CentralNotice both cause layout issues as well (and both of those are displayed for much longer periods of time, generally), perhaps it wouldn't be the worst idea to re-revert and help separate page content from the software stuff? 
Comment 14 Aaron Schulz 2008-09-11 06:26:26 UTC
(In reply to comment #13)
> Presumably, the new messages bar will only be visible for a very short time
> (until the user checks their messages). Seeing that the sitenotice and
> CentralNotice both cause layout issues as well (and both of those are displayed
> for much longer periods of time, generally), perhaps it wouldn't be the worst
> idea to re-revert and help separate page content from the software stuff? 
> 

I'd recommend that.
Comment 15 Mark Clements (HappyDog) 2008-11-25 04:23:18 UTC
Created attachment 5539 [details]
Alternative positioning suggestion.

Here is an alternative suggestion for message placement, which puts the user message at the top, along with the other user controls.  As far as I know this won't conflict with any existing messages/templates.

For reference, the CSS I used for this was as follows (though it could be improved, I'm sure):

.usermessage {
	position: absolute;
	right: 1em;
	top: -7.1em;
	font-size: 0.9em;
	padding: 0.2em 8.5em 0.3em;
	line-height: 0.9em;
	background-color: #FFFF00;
	font-weight: bold;
}

(Note that this was from <div> tag in a page preview, not the actual edit message, so it may not work 'out of the box', as it were!)
Comment 16 Mike.lifeguard 2008-11-25 04:26:01 UTC
(In reply to comment #13)
> Presumably, the new messages bar will only be visible for a very short time
> (until the user checks their messages). Seeing that the sitenotice and
> CentralNotice both cause layout issues as well (and both of those are displayed
> for much longer periods of time, generally), perhaps it wouldn't be the worst
> idea to re-revert and help separate page content from the software stuff? 
> 

Indeed. Seems like a trivial issue.
Comment 17 Umherirrender 2010-04-16 22:19:19 UTC
(In reply to comment #13)
> Presumably, the new messages bar will only be visible for a very short time
> (until the user checks their messages). Seeing that the sitenotice and
> CentralNotice both cause layout issues as well (and both of those are displayed
> for much longer periods of time, generally), perhaps it wouldn't be the worst
> idea to re-revert and help separate page content from the software stuff?


Yes, please split the content from other stuff.

I think, there is a solution for the problem of position from coordinate or other stuff.

Thanks.
Comment 18 p858snake 2011-04-30 00:09:01 UTC
*Bulk BZ Change: +Patch to open bugs with patches attached that are missing the keyword*
Comment 19 Sumana Harihareswara 2011-11-09 03:05:10 UTC
I've added the "design" keyword since this is a visual design issue, and the "reviewed" keyword since it seems the patch did get reviewed (please feel free to change that to "need-review" if you'd like some more discussion of the code suggested by Huji).
Comment 20 Umherirrender 2012-04-08 19:29:05 UTC
a possible fix commited with Gerrit change #4549
Comment 21 Brion Vibber 2012-04-09 17:41:59 UTC
Created attachment 10392 [details]
Current gerrit patch screenshot on Vector skin

Spacing under Vector is a bit off; not enough space above the title.
Comment 22 Brion Vibber 2012-04-09 17:42:39 UTC
Created attachment 10393 [details]
Current gerrit patch screenshot on Monobook skin

Very bad spacing, looks awful in monobook. :(

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links