Last modified: 2008-01-16 02:22:21 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
Bug 12636 - ExpandTemplates bugs when showing "Show XML parse tree" with old preprocessor parser
ExpandTemplates bugs when showing "Show XML parse tree" with old preprocessor...
Product: MediaWiki extensions
Classification: Unclassified
ExpandTemplates (Other open bugs)
All All
: Normal enhancement (vote)
: ---
Assigned To: Nobody - You can work on this!
: patch
Depends on:
  Show dependency treegraph
Reported: 2008-01-15 09:36 UTC by Alexandre Emsenhuber [IAlex]
Modified: 2008-01-16 02:22 UTC (History)
1 user (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

proposed patch (4.06 KB, patch)
2008-01-15 09:36 UTC, Alexandre Emsenhuber [IAlex]
new patch (4.05 KB, application/octet-stream)
2008-01-15 09:44 UTC, Alexandre Emsenhuber [IAlex]

Description Alexandre Emsenhuber [IAlex] 2008-01-15 09:36:41 UTC
Created attachment 4547 [details]
proposed patch

When using ExpandTemplates with an old preprocessor parser and checking "Show XML parse tree", like with Wikimedia sites (i think), the output is a blank screen as the extension try to call an undefined function Parser_OldPP::preprocessToDom(). I modified the extension to ckeck if that function is aviable, and, if not to not show that check box. I also modified it to use $wgSpecialPages to register the special page instead of extAddSpecialPage().
Comment 1 Tim Starling 2008-01-15 09:42:23 UTC
This is fixed in my working copy already. 
Comment 2 Alexandre Emsenhuber [IAlex] 2008-01-15 09:44:15 UTC
Created attachment 4548 [details]
new patch

oops, forgot debug code in the other patch.
Comment 3 Alexandre Emsenhuber [IAlex] 2008-01-15 09:45:58 UTC
ah, ok.
Comment 4 Tim Starling 2008-01-16 02:22:21 UTC
Fixed in r29821

Note You need to log in before you can comment on or make changes to this bug.