Last modified: 2008-01-14 18:13:06 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
Bug 12614 - Patch for SpecialUserrights.php to prevent logging of no changes (see URL)
Patch for SpecialUserrights.php to prevent logging of no changes (see URL)
Product: MediaWiki
Classification: Unclassified
Special pages (Other open bugs)
All All
: Normal enhancement (vote)
: ---
Assigned To: Aryeh Gregor (not reading bugmail, please e-mail directly)
: patch, patch-need-review
Depends on:
  Show dependency treegraph
Reported: 2008-01-13 20:55 UTC by Ryan Schmidt
Modified: 2008-01-14 18:13 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Patch for SpecialUserrights.php (881 bytes, patch)
2008-01-13 20:55 UTC, Ryan Schmidt

Description Ryan Schmidt 2008-01-13 20:55:47 UTC
Created attachment 4541 [details]
Patch for SpecialUserrights.php

The attached patch file patches SpecialUserrights.php to silently prevent the logging of rights changes if nothing is changed (such as the case in the link).
Comment 1 Roan Kattouw 2008-01-13 21:00:53 UTC
Can't this be done more cleanly? Like if(empty(array_diff($added, $removed)) && empty(array_diff($removed, $added)) ? (array_diff of course only lists elements present only in A and not in B, but not the other way around. Thanks, PHP!)
Comment 2 Ryan Schmidt 2008-01-13 21:08:16 UTC
marking as FIXED after a conversion w/ Simetrical in IRC (and a test on my local install after I ran the svn update) showed that this was already fixed in r29526
Comment 3 Gurch 2008-01-14 18:01:43 UTC
Reopening; despite r29526 having been live for a couple of days no-changes are still being logged. See for example
Comment 4 Aryeh Gregor (not reading bugmail, please e-mail directly) 2008-01-14 18:13:06 UTC
Should be fixed for real in r29756.

Note You need to log in before you can comment on or make changes to this bug.