Last modified: 2008-01-14 18:13:06 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T14614, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 12614 - Patch for SpecialUserrights.php to prevent logging of no changes (see URL)


Summary:	Patch for SpecialUserrights.php to prevent logging of no changes (see URL)

Status:	RESOLVED FIXED

Product:	MediaWiki
Classification:	Unclassified
Component:	Special pages (Other open bugs)
Version:	1.12.x
Hardware:	All All

Importance:	Normal enhancement (vote)
Target Milestone:	---
Assigned To:	Aryeh Gregor (not reading bugmail, please e-mail directly)

URL:	http://en.wikipedia.org/wiki/Wikipedi...
Whiteboard:
Keywords:	patch, patch-need-review

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2008-01-13 20:55 UTC by Ryan Schmidt
Modified:	2008-01-14 18:13 UTC (History)
CC List:	3 users (show)

See Also:
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
Patch for SpecialUserrights.php (881 bytes, patch) 2008-01-13 20:55 UTC, Ryan Schmidt	Details
Add an attachment (proposed patch, testcase, etc.)

Description Ryan Schmidt 2008-01-13 20:55:47 UTC

Created attachment 4541 [details]
Patch for SpecialUserrights.php

The attached patch file patches SpecialUserrights.php to silently prevent the logging of rights changes if nothing is changed (such as the case in the link).

Comment 1 Roan Kattouw 2008-01-13 21:00:53 UTC

Can't this be done more cleanly? Like if(empty(array_diff($added, $removed)) && empty(array_diff($removed, $added)) ? (array_diff of course only lists elements present only in A and not in B, but not the other way around. Thanks, PHP!)

Comment 2 Ryan Schmidt 2008-01-13 21:08:16 UTC

marking as FIXED after a conversion w/ Simetrical in IRC (and a test on my local install after I ran the svn update) showed that this was already fixed in r29526

Comment 3 Gurch 2008-01-14 18:01:43 UTC

Reopening; despite r29526 having been live for a couple of days no-changes are still being logged. See for example http://en.wikipedia.org/w/index.php?title=Special%3ALog&type=rights&page=User%3A+Deli+nk

Comment 4 Aryeh Gregor (not reading bugmail, please e-mail directly) 2008-01-14 18:13:06 UTC

Should be fixed for real in r29756.

Wikimedia Bugzilla is closed!

Search

Personal tools

Navigation

Links