Last modified: 2011-03-13 18:05:59 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
Bug 12580 - variable expansion in user supplied revert summary and more available variables in said summary
variable expansion in user supplied revert summary and more available variabl...
Status: RESOLVED WONTFIX
Product: MediaWiki
Classification: Unclassified
History/Diffs (Other open bugs)
unspecified
All All
: Lowest enhancement with 1 vote (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2008-01-10 16:49 UTC by Carl Fürstenberg
Modified: 2011-03-13 18:05 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Carl Fürstenberg 2008-01-10 16:49:28 UTC
the 'summary=' variable doesn't at the moment summary expansion of variables ($1 and $2 atm) for rollbacks.

Also, some more variables should be available imo:

$3: number of revisions reverted
$4: revid reverted to
$5: timestamp for revid reverted to
$6: revid reverted from
$7: timestamp for revid reverted from
$8: number of bytes reverted (±)
Comment 1 Aryeh Gregor (not reading bugmail, please e-mail directly) 2008-01-11 00:18:54 UTC
Surely the user can fill these in themselves.  Why is this needed?  We don't have expansion of variables in edit summaries, or anywhere else that's analogous to this.
Comment 2 Carl Fürstenberg 2008-01-11 17:25:19 UTC
(In reply to comment #1)
> Surely the user can fill these in themselves.  Why is this needed?  We don't
> have expansion of variables in edit summaries, or anywhere else that's
> analogous to this.
> 

There is variable expansion in the default rollback summary. Why I ask for this, is that you probably havn't gathered information to what revision you are reverting to.

Though, $8 isn't necessary.
Comment 3 Aryeh Gregor (not reading bugmail, please e-mail directly) 2008-01-11 17:46:23 UTC
The default rollback summary is a system message.  System messages need to have parameters, because they are not otherwise modifiable on a case-by-case basis.  Custom messages of any kind do not need programmatic variables that can be obtained easily from other places.  If a bot really thinks it's important to put in its custom message how many bytes were removed or whatever, it can calculate that itself.  The requested feature would be completely pointless for anyone not using a script or other customization of some kind (since by default you can't add a rollback reason); anyone using a script or other customization would probably have no use for most of the requested variables; and even if they did (for instance $2, which might not be immediately available in all cases), they could easily get the variables themselves.  Therefore this simply does not justify the required lines of code, in terms of code bloat, and does not justify breaking our practice in every other action summary of this type of printing the reason without any substitution of parameters.

I wasn't the one who closed this originally, but I'm reclosing it WONTFIX.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links