Last modified: 2008-07-20 14:29:49 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
Bug 12568 - Configuration script produces invalid HTML code
Configuration script produces invalid HTML code
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Installer (Other open bugs)
1.12.x
All All
: Normal normal (vote)
: ---
Assigned To: Nobody - You can work on this!
: patch
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2008-01-09 20:04 UTC by Alexandre Emsenhuber [IAlex]
Modified: 2008-07-20 14:29 UTC (History)
0 users

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
patch for config/index.php (19.41 KB, patch)
2008-01-09 20:04 UTC, Alexandre Emsenhuber [IAlex]
Details
second patch for config/index.php (21.01 KB, patch)
2008-01-12 16:44 UTC, Alexandre Emsenhuber [IAlex]
Details

Description Alexandre Emsenhuber [IAlex] 2008-01-09 20:04:37 UTC
Created attachment 4526 [details]
patch for config/index.php

Acutally, the w3.org's validator says that the code produced by the configuration script is invalid (5 errors and a lot of warnings). To resolve that problem, i changed the doc type to use the XHTML 1.0 transitional (the one used by the wiki) instead of the HTML 4.01 transitional and resolved the errors for the main possible results of the script (including some errors). I also updated some links to point to mediawiki.org instead of meta.wikimedia.org and modified the place of some comments in the generated LocalSettings.php.
Comment 1 Brion Vibber 2008-01-11 20:19:39 UTC
I notice there's some duplication here; '</ul><p>...</p>' is wrapped around nearly every error message. It might be better to factor that out to a common location.

If not all dieout points are within lists, it might be cleaner to maintain a list state to control that.
Comment 2 Alexandre Emsenhuber [IAlex] 2008-01-12 16:44:12 UTC
Created attachment 4538 [details]
second patch for config/index.php

dieout is used before the main list is open if the script finds the LocalSettings.php file or if the directory isn't writable. I introduced $mainListOpened variable for the current state. dieout will also add <p> if the text doesn't start with a <p> or <h1>...<h6> (if don't use preg_match because the script checks if that function exists and uses dieout if not).
Comment 3 Alexandre Emsenhuber [IAlex] 2008-07-20 14:29:49 UTC
fixed in r37870.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links