Last modified: 2008-01-09 01:09:11 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
Bug 12553 - Invalid XHTML rendered during edit conflict
Invalid XHTML rendered during edit conflict
Status: RESOLVED FIXED
Product: Wikimedia
Classification: Unclassified
wikibugs IRC bot (Other open bugs)
unspecified
All All
: Lowest trivial (vote)
: ---
Assigned To: Nobody - You can work on this!
: easy
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2008-01-08 19:29 UTC by Willemo
Modified: 2008-01-09 01:09 UTC (History)
0 users

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Willemo 2008-01-08 19:29:59 UTC
The following HTML fragment is rendered during an edit conflict:

<textarea tabindex=6 id='wpTextbox2' name="wpTextbox2" rows='25' cols='80' wrap='virtual'>

Two issues:
* tabindex attributes lacks quotes
* wrap='virtual' seems to be invalid XHTML according to the XHTML check of validator.w3.org

Probably the following line in EditPage.php needs to be changed from:

$wgOut->addHTML( "<textarea tabindex=6 id='wpTextbox2' name=\"wpTextbox2\" rows='{$rows}' cols='{$cols}' wrap='virtual'>"

into:

$wgOut->addHTML( "<textarea tabindex='6' id='wpTextbox2' name=\"wpTextbox2\" rows='{$rows}' cols='{$cols}'>"

(not sure about wrap, though)

I admit this is quite an unusual use case. Error is found in svn trunk yesterday.
Comment 1 Brion Vibber 2008-01-09 01:09:11 UTC
Fixed in r29474.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links