Last modified: 2009-08-24 20:38:59 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
Bug 12525 - [[MediaWiki:Summary-preview]] should be shown also with « Show changes »
[[MediaWiki:Summary-preview]] should be shown also with « Show changes »
Product: MediaWiki
Classification: Unclassified
Page editing (Other open bugs)
All All
: Normal enhancement with 1 vote (vote)
: ---
Assigned To: Nobody - You can work on this!
Depends on:
  Show dependency treegraph
Reported: 2008-01-06 04:10 UTC by lɛʁi לערי ריינהארט
Modified: 2009-08-24 20:38 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Implements the feature (1.42 KB, patch)
2009-03-06 20:29 UTC, Ben White

Description lɛʁi לערי ריינהארט 2008-01-06 04:10:51 UTC

At this moment [[MediaWiki:Summary-preview]] containing « Preview of edit summary: » is shown when « Show changes » ( [[MediaWiki:Showpreview]] ) is clicked / pressed. but not if « Show changes » ( [[MediaWiki:Showdiff]] ) is clicked / pressed.

enhancement request:

« Preview of edit summary: » should be available in both cases; if possible also in connection with « Live preview » ( [[MediaWiki:Showlivepreview]] ) .

Best regards Reinhardt [[user:Gangleri]]
Comment 1 Brion Vibber 2008-01-07 19:03:01 UTC
Not a preview, so it doesn't say preview.
Comment 2 lɛʁi לערי ריינהארט 2008-01-07 20:37:03 UTC
(In reply to comment #1)
> Not a preview, so it doesn't say preview.

Dear Brion, if you are fixing dozens of [[eroneous_nr_nn|pipe]] to [[correct_nr_nn|pipe]] the only way to verify the changes you made is the « Show changes » . The same applies for changes in the <includeonly>...</includeonly> parts of templates which do not display in preview.
Comment 3 Ben White 2009-03-06 20:20:19 UTC
Often I'm making changes to a page with intricate code, and the best way to see what I've done is to click "Show changes" instead of "Show preview". If I want to see a preview of my edit summary, however, I have to then click "Show preview". This is tedious not only because it requires a second step but also because if the page is long I now have to scroll all the way to the bottom to double-check that my summary is rendered correctly.

It would be very convenient if the summary preview were displayed on both "Show preview" and "Show changes", thus saving a step (and eliminating an unnecessary rendering of the page content itself).
Comment 4 Ben White 2009-03-06 20:29:11 UTC
Created attachment 5895 [details]
Implements the feature

The attachment is based on r48050 and implements the feature as described in the above comment.
Comment 5 Church of emacs 2009-08-17 14:36:31 UTC
Done in r55184.
Please note that I committed the code change before noticing this bug report. I didn't know about brions objections.
Nevertheless I think summary preview on "Show changes" is useful because:
* "Show preview" may load slowly on large pages; if you do only small changes (fixing typos), you don't want to preview the whole page. "Show changes" usually is faster and you instantly see your changes (with "Show preview" you have to search for the content you modified).
* If you undo changes your main focus is on the edit summary (where you should justify your revert), not the content itself.
* We want to encourage users to check their changes and their summary. Forcing them to click "Show changes" _and_ "Show preview" to check the content and the summary is not user friendly.
* Summary preview takes almost no space (so there isn't really a loss if the user doesn't care about the summary).
Comment 6 Alexandre Emsenhuber [IAlex] 2009-08-24 20:38:59 UTC
Marking bug as FIXED since r55184 is now marked as "ok".

Note You need to log in before you can comment on or make changes to this bug.