Last modified: 2012-12-16 17:43:09 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
Bug 12513 - ajaxwatch.js applies ID to wrong element, only processes one; tooltip doesn't update
ajaxwatch.js applies ID to wrong element, only processes one; tooltip doesn't...
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Interface (Other open bugs)
1.11.x
All All
: Normal trivial (vote)
: ---
Assigned To: Trevor Parscal
: patch, patch-need-review
Depends on:
Blocks: 43175
  Show dependency treegraph
 
Reported: 2008-01-05 06:04 UTC by Voyagerfan5761 / dgw
Modified: 2012-12-16 17:43 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
diff -u result of comparing the latest MediaWiki version with my working copy of ajaxwatch.js (577 bytes, patch)
2008-01-05 06:04 UTC, Voyagerfan5761 / dgw
Details
Updated diff to not cause issues with cologneblue et al (513 bytes, patch)
2008-01-05 06:32 UTC, Voyagerfan5761 / dgw
Details

Description Voyagerfan5761 / dgw 2008-01-05 06:04:48 UTC
Created attachment 4511 [details]
diff -u result of comparing the latest MediaWiki version with my working copy of ajaxwatch.js

When the function wgAjaxWatch.setLinkID() is called, it sets the ID passed to it on the <a> instead of the containing <li>. What happens, for example on a page that was initially unwatched, is that <li id="ca-watch"><a> turns into <li id="ca-watch"><a id="ca-unwatch"> when the user clicks the tab to watch the page. I've attached a diff that applies the ID to the <li> instead, and loops through all the links in the wgAjaxWatch.watchLinks array to change their IDs (note: I've only tested on Monobook).

I hoped to fix the tooltip update problem by fixing the ID assignment glitch, but it hasn't worked. For that part of the bug, I have no patch.

Hopefully this trivial change will be committed by someone, then the tooltip problem can be worked on.
Comment 1 Voyagerfan5761 / dgw 2008-01-05 06:23:36 UTC
Ecch, scratch that patch; it breaks cologneblue and classic, at the very least. Back to the drawing board...
Comment 2 Voyagerfan5761 / dgw 2008-01-05 06:32:33 UTC
Created attachment 4512 [details]
Updated diff to not cause issues with cologneblue et al

This one shouldn't cause problems in cologneblue or classic (tested and no problems for me). Still no ideas on the tooltip thing, though.
Comment 3 Brion Vibber 2009-07-20 04:27:17 UTC
Another AJAX/UI coding tweak for the UI team to check out the status on... :)

Note some of the old classic skins include two watch links, I believe (sidebar and top bar, or top and bottom, or some such thing)
Comment 4 DieBuche 2010-12-14 16:03:40 UTC
Both fixed by Krinkle in /phase3/resources/mediawiki.action/mediawiki.action.watch.ajax.js

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links