Last modified: 2011-07-11 12:00:29 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
Bug 12474 - add garish CSS to use mw-anon-edit-warning
add garish CSS to use mw-anon-edit-warning
Status: RESOLVED WONTFIX
Product: MediaWiki
Classification: Unclassified
Page editing (Other open bugs)
1.12.x
All All
: Low enhancement (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks: css
  Show dependency treegraph
 
Reported: 2008-01-01 22:34 UTC by Dan Jacobson
Modified: 2011-07-11 12:00 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Dan Jacobson 2008-01-01 22:34:02 UTC
Simetrical> I've added the ID mw-anon-edit-warning in r28786.
That should be CLASS not ID.
Also the PREVIEW pages should have the warning too, as they might have
missed it on the first edit page.
Comment 1 Aryeh Gregor (not reading bugmail, please e-mail directly) 2008-01-01 23:03:00 UTC
You seem to have two separate requests, not one:

1) The mw-anon-edit-warning ID should become a class.  Why do you want this?  IDs work just as well as classes for CSS.

2) Preview pages should have the warning too.  Debatable whether this is needed, I don't really think so enough to do this.  You got the message once, I don't want to clutter the top of the screen with unneeded info.
Comment 2 Dan Jacobson 2008-01-01 23:22:37 UTC
All I know is that in ~/.mozilla/firefox/*.default/chrome/userContent.css,
the last line of

/* Wikipedia: */
a.new  { background-color: silver; }
a.stub { background-color: grey; }
div.mw-anon-edit-warning { background-color: orange; text-decoration: underline; }

only worked if I edited the rendered HTML to say class and not id.


Sorry for not making two bugs.  There is a 25% chance users will notice the message upon each refresh... decreasing into the heat of the edit... 25+20+15+10... the will notice it sooner or later hopefully before they hit Save.

Best would be background "Edit Edit" slanted as in other wikis, and even "not logged in ... edit..." Wait, I don't let anything other than the HTML past WWWOFFLE, so, Your (judgement) call here. Better yet: electrodes to the balls...

Comment 3 Roan Kattouw 2008-01-01 23:24:25 UTC
Changing div.mw-anon-edit-warning to div#mw-anon-edit-warning or just #mw-anon-edit-warning (i.e. change the dot to a pound sign) fixes this.
Comment 4 Aryeh Gregor (not reading bugmail, please e-mail directly) 2008-01-01 23:32:05 UTC
(In reply to comment #2)
> All I know is that in ~/.mozilla/firefox/*.default/chrome/userContent.css,
> the last line of
> 
> /* Wikipedia: */
> a.new  { background-color: silver; }
> a.stub { background-color: grey; }
> div.mw-anon-edit-warning { background-color: orange; text-decoration:
> underline; }
> 
> only worked if I edited the rendered HTML to say class and not id.

Because your CSS selector is for a class, not an ID.  It needs to use #mw-anon-edit-warning, as Roan says.

> Sorry for not making two bugs.  There is a 25% chance users will notice the
> message upon each refresh... decreasing into the heat of the edit...
> 25+20+15+10... the will notice it sooner or later hopefully before they hit
> Save.

I don't agree with the necessity of this.  We already have extra lines of content up at the top on preview, I'm not inclined to add more.  If the notice isn't visible enough on the first edit, it probably won't be visible enough on subsequent edits.  Marking WONTFIX, as far as I'm concerned, although if some other developer disagrees and wants to implement this, they can reopen and that's their business.
Comment 5 Dan Jacobson 2008-01-10 18:59:52 UTC
OK anyway, now that there is a style, can you please begin to use it in the skins.
Perhaps not as garish as
div#mw-anon-edit-warning { background-color: orange; text-decoration: underline; }
but something at least.

You see just today. a beloved user on my wiki has mistakenly edited while not logged in,
leaving his company's IP address in the history of A_Sensitive_Article
and RecentChanges, etc.  Now he is imploring me to expunge his IP.
I could say "didn't you see the warning in garish orange?" if only it were...
Yes I could hack it for my wiki but I'm sure this is a common problem.

Comment 6 DieBuche 2011-07-11 10:11:22 UTC
That's exactly what common.css is for: 
For CSS that's not appropriate in every MW install, but in yours.
Comment 7 Dan Jacobson 2011-07-11 12:00:29 UTC
Well OK then. Thanks.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links