Last modified: 2014-11-17 10:35:25 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
Bug 12472 - Remove leading dashes from signature button on the edit toolbar
Remove leading dashes from signature button on the edit toolbar
Status: RESOLVED WONTFIX
Product: MediaWiki
Classification: Unclassified
General/Unknown (Other open bugs)
unspecified
All All
: Low enhancement with 2 votes (vote)
: ---
Assigned To: Nobody - You can work on this!
: design, patch, patch-need-review
: 12468 25216 (view as bug list)
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2008-01-01 19:55 UTC by rememberthedot
Modified: 2014-11-17 10:35 UTC (History)
7 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
EditPage.php patch (65.41 KB, patch)
2008-01-01 19:55 UTC, rememberthedot
Details
EditPage.php patch in unified diff format (558 bytes, patch)
2008-01-02 02:54 UTC, rememberthedot
Details

Description rememberthedot 2008-01-01 19:55:09 UTC
Created attachment 4491 [details]
EditPage.php patch

The "Your signature with timestamp" button on the edit toolbar should generate ~~~~, not --~~~~. The extra dashes make it inconsistent with the character map below the edit box which uses ~~~~, and they also interfere with users who include the dashes in their custom signature.

This has been an issue for some time. See http://en.wikipedia.org/w/index.php?title=Wikipedia:Village_pump_%28proposals%29&oldid=181428756#Disparity_between_signature_.28.7E.7E.7E.7E.29_toolbar_buttons_and_character_map for an example of Wikipedians annoyed by this issue.

The fix to this is extremely simple. I've created a patch, based on MediaWiki 1.11.0, that works excellently.
Comment 1 Sean Smith 2008-01-02 01:04:40 UTC
This should be an open and shut case right? Just implement the patch and achieve consistency.
Comment 2 Robert Leverington 2008-01-02 01:15:34 UTC
The button in question has always produce --~~~~ so the fact that it is inconsistent with the character map below the edit box is completely irrelevant as the character map is done on a wiki-by-wiki basis and is not part of the core code. I'm sure it would be possible to write a JavaScript function that replaces it.

An alternate solution would be to create a new interface message so it could be customized on a per-wiki basis -- I'm renaming this bug to that effect, although I would suggest this be closed as WONTFIX.

Also patches should be submitted in unified diff format, not the entire file, so they can be easily patched into the code.
Comment 3 rememberthedot 2008-01-02 01:50:15 UTC
Isn't there already [[MediaWiki:Signature]] for customizing signature behavior? Doesn't it make more sense for wikis to use that if they want to add leading dashes to signatures? Creating yet another interface message is not what we want at all. We just want the leading dashes gone from the edit toolbar, and we can put them into [[MediaWiki:Signature]] if there is consensus to do so.
Comment 4 Robert Leverington 2008-01-02 01:53:20 UTC
Fair enough, thank you for the clarification, in this case I suggest you submit a patch that adds them to the default MediaWiki:Signature message (probably in languages/messages/MessagesEn.php) and removes them from the edit toolbar as you have already demonstrated a patch for. If you submit it in unified diff format on a copy of the latest SVN trunk then it will most likely get quickly commited.
Comment 5 rememberthedot 2008-01-02 02:54:15 UTC
Created attachment 4492 [details]
EditPage.php patch in unified diff format

OK, here is the same patch I submitted before, but in unified diff format. I looked and looked but couldn't find where the default value of Mediawiki:Signature and Mediawiki:Signature-ip is kept. It is a good idea to add the dashes there, but I just can't find the right file to edit.
Comment 6 MZMcBride 2008-01-02 03:26:20 UTC
I'll echo Minute's comments that that particular button has given --~~~~ for an incredibly long time, and a change to its function would be abrupt, and I would guess most likely unwelcome, by everyday editors.
Comment 7 rememberthedot 2008-01-02 04:39:59 UTC
If we change the default signature to include the two dashes, then it would alleviate the problem, and I suspect that most users use ~~~~ instead of --~~~~ anyway.
Comment 8 Rotem Liss 2008-01-02 15:15:24 UTC
*** Bug 12468 has been marked as a duplicate of this bug. ***
Comment 9 Brion Vibber 2008-01-02 18:23:00 UTC
Changing the default sig would be disruptive for all those times you want to use the sig in eg voting or other areas where you don't want a preceding dash. I'm a bit leery of changing the toolbar button either since it's been this way for some time.

Consistency on that particular wiki may be achieved by making the custom edit tool congruent with the standard toolbar.
Comment 10 Umherirrender 2010-10-08 17:46:09 UTC
*** Bug 25216 has been marked as a duplicate of this bug. ***
Comment 11 Trevor Parscal 2010-10-08 17:56:01 UTC
It seems like we need to be consistent above all else. The question is, what is the functional purpose of the dashes? Is this documented anywhere?

This is probably the easiest thing to fix ever, but I don't want to "fix" it only to get slapped by someone else.
Comment 12 MZMcBride 2010-10-08 23:39:32 UTC
(In reply to comment #11)
> It seems like we need to be consistent above all else. The question is, what is
> the functional purpose of the dashes? Is this documented anywhere?

I think it makes copying and pasting much clearer. You're more likely to realize when the message has ended and the username has begun with the two dashes.

> This is probably the easiest thing to fix ever, but I don't want to "fix" it
> only to get slapped by someone else.

LiquidThreads is presumably going to replace most wiki-page discussions, so I'm not sure if it's worth changing this for the sake of changing it at this point. I'm biased in that I like the current default, though.
Comment 13 p858snake 2011-04-30 00:09:29 UTC
*Bulk BZ Change: +Patch to open bugs with patches attached that are missing the keyword*
Comment 14 Sam Reed (reedy) 2011-11-19 19:32:09 UTC
WONTFIXING per above. It's just stupid changing the default for arbitary reasons

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links