Last modified: 2011-04-14 15:13:00 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T14458, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 12458 - Protected page titles should show only one protection notice
Protected page titles should show only one protection notice
Status: REOPENED
Product: MediaWiki
Classification: Unclassified
Page editing (Other open bugs)
1.11.x
All All
: Low enhancement (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2007-12-30 20:18 UTC by CBM
Modified: 2011-04-14 15:13 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description CBM 2007-12-30 20:18:03 UTC
Currently, if an editor tries to create a page protected from creation, without rights, they will get two error messages from Title.php: MediaWiki:Protectedpagetext and MediaWiki:Titleprotected. Because of the order of the code, the protectedpagetext message comes first, which leads to confusing messages for the user. To be user friendly, we need to give the titleprotected message first, or (better) not give the protectedpagetext message at all when the titleprotected message will later be output.
Comment 1 MZMcBride 2007-12-30 20:54:25 UTC
Also, the current set-up requires an unordered list, so div boxes are used with bullets. Perhaps we could remove the hard-coded bullets?
Comment 2 Aryeh Gregor (not reading bugmail, please e-mail directly) 2008-01-09 21:00:57 UTC
The bullets are a separate issue, file a separate bug.  They aren't hard-coded, you can remove them with CSS.
Comment 3 Aryeh Gregor (not reading bugmail, please e-mail directly) 2008-01-09 21:38:11 UTC
This is more complicated than I thought.  The logic here needs serious cleaning up.
Comment 4 Aaron Schulz 2009-01-03 13:28:10 UTC
Done in r45367
Comment 5 Brion Vibber 2009-01-07 04:32:02 UTC
Reverted for now in r45488; the logic looks really funky and I'm not convinced from a first look that it's right. (Test cases would be awesome here! :)

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links