Last modified: 2007-12-31 21:10:05 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T14446, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 12446 - Fix permissions check when displaying "Undelete n edits" tab
Fix permissions check when displaying "Undelete n edits" tab
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Interface (Other open bugs)
1.12.x
All All
: Normal minor (vote)
: ---
Assigned To: Nobody - You can work on this!
: patch
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2007-12-29 19:07 UTC by Alexandre Emsenhuber [IAlex]
Modified: 2007-12-31 21:10 UTC (History)
0 users

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
proposed patch for Skin.php and SkinTemplate.php (1016 bytes, patch)
2007-12-29 19:07 UTC, Alexandre Emsenhuber [IAlex] 		Details
Add an attachment (proposed patch, testcase, etc.)

Description Alexandre Emsenhuber [IAlex] 2007-12-29 19:07:37 UTC 
Created attachment 4483 [details]
proposed patch for Skin.php and SkinTemplate.php

Actually, to show the tab "Undelete n edits" in toolbar (for Skins that extends SkinTemplates) MediaWiki checks if the user has 'delete' or 'undelete' permissions, but if he doesn't have the 'deletedhistory' permission, he'll get a "Permission error" (strange configuration of $wgGroupPermissions, i know). I also modified Skin.php to display "view and restore n deleted edits" instead of "view n deleted edits" if the user has 'undelete' right as after r28151, the user must have the 'undelete' permission (and not the 'delete' one) to restore pages.
Comment 1 Brion Vibber 2007-12-31 21:10:05 UTC 
Applied in r29129 -- thanks for the patch!
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links