Last modified: 2007-12-31 21:10:05 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
Bug 12446 - Fix permissions check when displaying "Undelete n edits" tab
Fix permissions check when displaying "Undelete n edits" tab
Product: MediaWiki
Classification: Unclassified
Interface (Other open bugs)
All All
: Normal minor (vote)
: ---
Assigned To: Nobody - You can work on this!
: patch
Depends on:
  Show dependency treegraph
Reported: 2007-12-29 19:07 UTC by Alexandre Emsenhuber [IAlex]
Modified: 2007-12-31 21:10 UTC (History)
0 users

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

proposed patch for Skin.php and SkinTemplate.php (1016 bytes, patch)
2007-12-29 19:07 UTC, Alexandre Emsenhuber [IAlex]

Description Alexandre Emsenhuber [IAlex] 2007-12-29 19:07:37 UTC
Created attachment 4483 [details]
proposed patch for Skin.php and SkinTemplate.php

Actually, to show the tab "Undelete n edits" in toolbar (for Skins that extends SkinTemplates) MediaWiki checks if the user has 'delete' or 'undelete' permissions, but if he doesn't have the 'deletedhistory' permission, he'll get a "Permission error" (strange configuration of $wgGroupPermissions, i know). I also modified Skin.php to display "view and restore n deleted edits" instead of "view n deleted edits" if the user has 'undelete' right as after r28151, the user must have the 'undelete' permission (and not the 'delete' one) to restore pages.
Comment 1 Brion Vibber 2007-12-31 21:10:05 UTC
Applied in r29129 -- thanks for the patch!

Note You need to log in before you can comment on or make changes to this bug.