Last modified: 2008-08-18 19:40:16 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
Bug 12395 - Watching when editing does not work
Watching when editing does not work
Status: RESOLVED INVALID
Product: MediaWiki
Classification: Unclassified
Page editing (Other open bugs)
unspecified
All All
: Normal minor (vote)
: ---
Assigned To: Nobody - You can work on this!
:
: 13813 15231 (view as bug list)
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2007-12-23 21:16 UTC by Robin Pepermans (SPQRobin)
Modified: 2008-08-18 19:40 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Robin Pepermans (SPQRobin) 2007-12-23 21:16:52 UTC
The following does not work
* I am editing a page
* then I realize that I want to watch that page
* so I click on "watch" (opening in other tab/window)
* I think, ok, I'm watching that page, so I close that tab/window
* I am still editing that page, so I go back to the edit form and I click on "save"
* I notice that I am not watching the page, even after clearing the cache

I tried it several times but this does not work.

Thank you, [[m:User:SPQRobin]].
Comment 1 Robert Leverington 2007-12-23 22:10:41 UTC
I can verify this, however it should be noted that this is of very low priority given that you no longer need\should make the watch page open in a new window as an AJAX-y thing causes you to not even leave the page you are on and still watch the page (so you won't loose any edits you are making).
Comment 2 Brion Vibber 2007-12-24 05:18:39 UTC
The cause of this would be that the 'watch this page' checkbox state on the still-open edit page will not have changed. When the save request is submitted, that value (watched or unwatched) will be applied.

I should note that this issue is present without opening a new tab/window as well. Both the AJAX tab action (without leaving the page) and a direct link followed by the back button (eg with no JavaScript or no XmlHttpRequest) will result in the same behavior.

One solution might be to record both the original state at open time and the checked state, only applying the change if there was a change made. This would keep stale checkbox state from overriding things unexpectedly.
Comment 3 Roan Kattouw 2007-12-26 17:40:03 UTC
(In reply to comment #2)
> One solution might be to record both the original state at open time and the
> checked state, only applying the change if there was a change made. This would
> keep stale checkbox state from overriding things unexpectedly.
We could also have the JavaScript that does the AJAX thingy check the checkbox. That would only break if someone:

1. Opened an edit form in tab A
2. Opened the same edit form in tab B
3. Clicked "watch" in tab A
4. Submits an edit in tab B

But that's kind of stupid...
Comment 4 Brion Vibber 2008-04-21 19:59:05 UTC
*** Bug 13813 has been marked as a duplicate of this bug. ***
Comment 5 Aaron Schulz 2008-08-03 19:33:08 UTC
This is too contrived a scenario to be worth the code changes. 

I did tweak AJAX watch in r38512 to update the checkbox however.

Comment 6 Aaron Schulz 2008-08-18 19:40:16 UTC
*** Bug 15231 has been marked as a duplicate of this bug. ***

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links