Last modified: 2008-03-19 00:28:33 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
Bug 12269 - FileSearchIndexer.php code review
FileSearchIndexer.php code review
Product: MediaWiki extensions
Classification: Unclassified
General/Unknown (Other open bugs)
All All
: Normal trivial (vote)
: ---
Assigned To: Nobody - You can work on this!
: patch, patch-need-review
Depends on:
  Show dependency treegraph
Reported: 2007-12-10 18:50 UTC by Alno
Modified: 2008-03-19 00:28 UTC (History)
0 users

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

typos and variable name corrections (691 bytes, patch)
2007-12-10 18:50 UTC, Alno

Description Alno 2007-12-10 18:50:49 UTC
Created attachment 4430 [details]
typos and variable name corrections

Bugs found while reviewing MediaWiki extensions code in Eclipse 3.3
Comment 1 Brion Vibber 2008-03-19 00:28:33 UTC
The code appears quite correct as it is; patch would break it.

getExtractor() instantiates the appropriate class for a given MIME type and returns the object, or null if no class is registered for that type.

Patch would return the class name instead of a new instance of the class, causing the code to fail.

Note You need to log in before you can comment on or make changes to this bug.