Last modified: 2008-03-19 00:28:33 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T14269, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 12269 - FileSearchIndexer.php code review
FileSearchIndexer.php code review
Status: RESOLVED INVALID
Product: MediaWiki extensions
Classification: Unclassified
General/Unknown (Other open bugs)
unspecified
All All
: Normal trivial (vote)
: ---
Assigned To: Nobody - You can work on this!
: patch, patch-need-review
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2007-12-10 18:50 UTC by Alno
Modified: 2008-03-19 00:28 UTC (History)
0 users

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
typos and variable name corrections (691 bytes, patch)
2007-12-10 18:50 UTC, Alno 		Details
Add an attachment (proposed patch, testcase, etc.)

Description Alno 2007-12-10 18:50:49 UTC 
Created attachment 4430 [details]
typos and variable name corrections

Bugs found while reviewing MediaWiki extensions code in Eclipse 3.3
Comment 1 Brion Vibber 2008-03-19 00:28:33 UTC 
The code appears quite correct as it is; patch would break it.

getExtractor() instantiates the appropriate class for a given MIME type and returns the object, or null if no class is registered for that type.

Patch would return the class name instead of a new instance of the class, causing the code to fail.
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links