Last modified: 2008-09-11 16:42:24 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T14233, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 12233 - #ifexist limit exceeding should be indicated on the page
#ifexist limit exceeding should be indicated on the page
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
ParserFunctions (Other open bugs)
unspecified
All All
: High enhancement with 4 votes (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks: 11691
  Show dependency treegraph
 
Reported: 2007-12-07 19:36 UTC by Kalan
Modified: 2008-09-11 16:42 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Kalan 2007-12-07 19:36:25 UTC
At the moment, many pages are exceeding the proposed #ifexist per-page limit of 100. (Currently this limit is set to 2000, which is already exceeded by some pages). I predict that on the day the new proposed limit is put into operation, some pages will silently break, and there will be tons of "omg!!!111oneone Y my [[page]] doesn't work???77"-like flood in #mediawiki or #wikimedia-tech, and many more editors will be at least confused.

So, after the short discussion with Tim Starling, I propose the following:

* If the amount of #ifexist usage on the page is less or equal to 100, it should be indicated only by a comment at the bottom of the rendered HTML (as it is now).
* Otherwise, if it's greater than 100, the warning should be put just before the categories (making it always visible). For &live, the message should go to the very end of output. This warning should be big and red, and a message (I propose to name it [[MediaWiki:ifexist-limit-exceeded]]) with $1 and $2 for usage amount and limit would be nice.

I've set the bug priority to high, because I think that this should be done before the limit is lowered.
Comment 1 ais523 2007-12-09 11:05:20 UTC
This seems like a good idea; however, I suggest that it should be not just for the #ifexist limits but for the other template limits as well (pre-expand include limit in particular); when a page stops working, it's useful to inform users why. It could say something like "Warning: this page has not been processed correctly because it was too complicated: more than 100 #ifexists on page", changing the reason as appropriate.
Comment 2 Tim Starling 2007-12-10 06:12:09 UTC
Proposed solution in r28336/r28337: warning on preview plus place the page in a category. 
Comment 3 Mormegil 2008-09-11 16:42:24 UTC
Solution implemented and commited, available since 1.12, the improved version has already been deployed on Wikimedia servers (see e.g. http://en.wikipedia.org/wiki/Category:Pages_with_too_many_expensive_parser_function_calls). Marking as RESOLVED FIXED.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links