Last modified: 2007-11-27 18:19:08 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T14132, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 12132 - ProofreadPage loads image directly from upload.wikimedia.org
ProofreadPage loads image directly from upload.wikimedia.org
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
ProofreadPage (Other open bugs)
unspecified
All All
: Normal trivial (vote)
: ---
Assigned To: Nobody - You can work on this!
: patch
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2007-11-27 18:13 UTC by Thomas Bleher
Modified: 2007-11-27 18:19 UTC (History)
0 users

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Thomas Bleher 2007-11-27 18:13:28 UTC
proofread.js from the ProofreadPage extension directly loads the file http://upload.wikimedia.org/wikipedia/commons/2/2a/Button_category_plus.png . Instead, it should include the file in the extension directory (some other images are already there) and load it from there.

The relevant patch:

--- a/extensions/ProofreadPage/proofread.js
+++ b/extensions/ProofreadPage/proofread.js
@@ -208,7 +208,7 @@ function proofreadpage_default_setup() {
                        image.width = 23;
                        image.height = 22;
                        image.className = "mw-toolbar-editbutton";
-                       image.src = "http://upload.wikimedia.org/wikipedia/commons/2/2a/Button_category_plus.png";
+                       image.src = wgScriptPath+'/extensions/ProofreadPage/Button_category_plus.png';
                        image.border = 0;
                        image.alt = proofreadPageMessageToggleHeaders;
                        image.title = proofreadPageMessageToggleHeaders;
Comment 1 Brion Vibber 2007-11-27 18:19:08 UTC
Fixed in r27899

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links