Last modified: 2010-05-15 15:59:38 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T14122, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 12122 - Images in dumpHTML broken
Images in dumpHTML broken
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
General/Unknown (Other open bugs)
1.11.x
All All
: Normal normal with 1 vote (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2007-11-26 15:27 UTC by Tim Starling
Modified: 2010-05-15 15:59 UTC (History)
0 users

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Tim Starling 2007-11-26 15:27:18 UTC
Since the filerepo changes in 1.11, dumpHTML.php no longer properly configures the file URLs. The generated HTML will incorrectly contain absolute URLs instead of relative to the document, and the --image-snapshot feature is broken. 

Also, there is no support for arbitrary repository configured via $wgLocalFileRepo and $wgForeignFileRepos, only the legacy globals are used. 

A temporary workaround suitable for installations with only one file repository is as follows:

Index: dumpHTML.inc
===================================================================
--- dumpHTML.inc	(revision 27666)
+++ dumpHTML.inc	(working copy)
@@ -593,7 +593,8 @@
 			'src="' . htmlspecialchars( $wgScriptPath ) . '/images', $this->oldCopyrightIcon );
 
 		$wgStylePath = "$wgScriptPath/skins";
-		$wgUploadPath = "$wgScriptPath/{$this->imageRel}";
+		$repo = RepoGroup::singleton()->getLocalRepo();
+		$repo->url = $wgUploadPath = "$wgScriptPath/{$this->imageRel}";
 		$wgSharedUploadPath = "$wgUploadPath/shared";
 		$wgMaxCredits = -1;
 		$wgHideInterlanguageLinks = !$this->interwiki;
Comment 1 Tim Starling 2008-02-27 05:53:04 UTC
This is fixed now in the DumpHTML extension.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links