Last modified: 2012-08-04 20:49:04 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T13952, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 11952 - DatabasePostgres.php does not quote all schema names


Summary:	DatabasePostgres.php does not quote all schema names

Status:	RESOLVED FIXED

Product:	MediaWiki
Classification:	Unclassified
Component:	Database (Other open bugs)
Version:	1.11.x
Hardware:	All All

Importance:	Normal normal (vote)
Target Milestone:	---
Assigned To:	Nobody - You can work on this!

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:	postgres
	Show dependency tree / graph

Reported:	2007-11-12 14:13 UTC by Jutta Horstmann
Modified:	2012-08-04 20:49 UTC (History)
CC List:	2 users (show)

See Also:
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
Necessary changes to DatabasePostgres.php (598 bytes, patch) 2007-11-12 14:13 UTC, Jutta Horstmann	Details
Add an attachment (proposed patch, testcase, etc.)

Description Jutta Horstmann 2007-11-12 14:13:32 UTC

Created attachment 4332 [details]
Necessary changes to DatabasePostgres.php

To support schema names containing dashes (like "my-cool-schema"), the schema name has to be double-quoted in SQL statements.
Throughout DatabasePostgres.php this is done by using the quote_ident() function.

But there is one missing spot: In setup_database(), while testing the writeability of the schema, 
$wgDBmwschema is used unquoted in SQL statements, leading to errors.

The diff is attached.

Regards,
Jutta

Comment 1 Greg Sabino Mullane 2007-12-06 17:56:17 UTC

Thanks, applied patch plus some other similar problems in r28214

Wikimedia Bugzilla is closed!

Search

Personal tools

Navigation

Links