Last modified: 2008-03-09 10:35:59 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
Bug 11923 - Default group for Oversight extension
Default group for Oversight extension
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
Oversight (Other open bugs)
unspecified
All All
: Normal enhancement (vote)
: ---
Assigned To: Brion Vibber
:
: 13293 (view as bug list)
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2007-11-10 15:50 UTC by MF-Warburg
Modified: 2008-03-09 10:35 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description MF-Warburg 2007-11-10 15:50:50 UTC
The Oversight extension does not define default groups in its code, so installing this extension from svn and changing nothing, results in nobody is able to hide revisions. Furthermore, since on Wikimedia something like
$wgGroupPermissions['oversight']['hiderevision'] = true;
$wgGroupPermissions['oversight']['oversight'] = true;
is used, I think this should be added to HideRevision.php as default group, so it would be also possible to translate the name of that group.
Comment 1 Raimond Spekking 2008-03-08 19:19:18 UTC
*** Bug 13293 has been marked as a duplicate of this bug. ***
Comment 2 Huji 2008-03-08 21:16:58 UTC
Well, I see no reason why we should avoid this. The only thing to take care of is to update LocalSettings for Wikimedia wikis to avoid double definition of 'oversight' group after it is hardcoded in the Extension code.
Comment 3 Robert Leverington 2008-03-08 21:26:37 UTC
Double definition will not be an issue, since both Wikimedia and the defualt will be the same the later (Wikimedia) will just override the former (the default) - and both are identical. It wouldn't hurt to remove it, but I don't see any reason why this is essential.
Comment 4 Daniel Friesen 2008-03-09 10:30:37 UTC
Honestly, I'm strongly against hardcoding any special groups inside of extensions.

I personally get annoyed whenever groups like 'interwiki', 'oversight', 'checkuser', etc... are hardcoded into extensions.

I like to use SVN to setup extensions on wiki, which allows be to easily 'svn update' to update the extension. But I have absolutely no need for these extra groups on wiki I've worked on in the past, this kind of stuff has always been something I'd configure as part of a 'staff' group. The extra hardcoded groups just clutters up the groups list with irrelevant and unnecessary groups. And what is really annoying is the fact that since it's hardcoded into the extension, I cannot remove it unless I edit the extension, which voids out my ability to simply 'svn update' anymore and forces me to decide on whether I want to be able to easily update the extension, or I want to remove crap that shouldn't even be hardcoded inside of it.

So IMHO, these groups should NOT be hardcoded into extensions. If you absolutely want some sort of hardcoding for these, I recommend creating some sort of file like Oversight-groups.php which can !Optionally! be included into LocalSettings.php if the user really wants the extra groups. It shouldn't be forced on the smaller wiki which don't want them.
Comment 5 Andrew Garrett 2008-03-09 10:35:59 UTC
(In reply to comment #4)
> I like to use SVN to setup extensions on wiki, which allows be to easily 'svn
> update' to update the extension. But I have absolutely no need for these extra
> groups on wiki I've worked on in the past, this kind of stuff has always been
> something I'd configure as part of a 'staff' group. The extra hardcoded groups
> just clutters up the groups list with irrelevant and unnecessary groups. And
> what is really annoying is the fact that since it's hardcoded into the
> extension, I cannot remove it unless I edit the extension, which voids out my
> ability to simply 'svn update' anymore and forces me to decide on whether I
> want to be able to easily update the extension, or I want to remove crap that
> shouldn't even be hardcoded inside of it.

unset($wgGroupPermissions['oversight']);

Fixed in r31729.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links