Last modified: 2011-02-14 01:19:37 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T13852, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 11852 - Inconsistent handling of message cache key normalisation
Inconsistent handling of message cache key normalisation
Status: RESOLVED INVALID
Product: MediaWiki
Classification: Unclassified
General/Unknown (Other open bugs)
unspecified
All All
: Normal normal with 1 vote (vote)
: ---
Assigned To: Nobody - You can work on this!
: patch, patch-need-review
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2007-11-02 10:13 UTC by OSRC Sysint Team
Modified: 2011-02-14 01:19 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
normalises keys that are added to MessageCache (1.03 KB, patch)
2007-11-02 10:13 UTC, OSRC Sysint Team 		Details
Add an attachment (proposed patch, testcase, etc.)

Description OSRC Sysint Team 2007-11-02 10:13:59 UTC 
Created attachment 4299 [details]
normalises keys that are added to MessageCache

The following bug was found and examined in mediawiki 1.10.0 but a short look at the source code of 1.11 lets me assume its still in there too. Version 1.8 is not affected.

The method get() of the class MessageObject in include/MessageCache.php enforces message normalisation by lowercasing the first char of a key and replacing all underscores with blanks in these keys. Since this normalisation is not applied when messages are stored in the cache (e.g. by method addMessages), this breaks extensions which do not us normalised keys (like PageProtectionPlus). The attached patch applies normalisation on message adding.
Comment 1 Aaron Schulz 2008-09-28 15:26:38 UTC 
Not really worth the overhead. The extensions that misuse this should be fixed.
Comment 2 Aryeh Gregor (not reading bugmail, please e-mail directly) 2008-10-07 15:17:33 UTC 
(In reply to comment #1)
> Not really worth the overhead. The extensions that misuse this should be fixed.

What overhead?  It's like a five-line fix and reportedly a regression.
Comment 3 Aaron Schulz 2009-02-17 15:36:56 UTC 
Partly done in r47362
Comment 4 Chad H. 2011-02-14 01:19:37 UTC 
addMessages() doesn't exist anymore. Nothing really to fix here, marking INVALID.
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links