Last modified: 2007-12-06 09:42:48 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
Bug 11810 - Displayed semicolons should be localizable
Displayed semicolons should be localizable
Product: MediaWiki
Classification: Unclassified
Internationalization (Other open bugs)
All All
: Normal normal (vote)
: ---
Assigned To: Nobody - You can work on this!
Depends on:
  Show dependency treegraph
Reported: 2007-10-29 16:59 UTC by Roozbeh Pournader
Modified: 2007-12-06 09:42 UTC (History)
1 user (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Patch to fix the issue (partially untested) (2.56 KB, patch)
2007-11-18 14:14 UTC, Roozbeh Pournader

Description Roozbeh Pournader 2007-10-29 16:59:18 UTC
There are different places in MediaWiki that a semicolon is used to separate list of usernames, separate a timestamp from a page name, etc.

These are done using hard-coded strings of semicolon followed by space, '; ', which cannot be localized, as is required for languages that use the Arabic and Syriac scripts, including Persian. Persian uses a different Unicode character for semicolon, namely U+061B, ARABIC SEMICOLON.

Example of such could be seen here:
(search for ;)

All uses of semicolon that is displayed to the user should be localizable. I guess this could be best achieved by definining a localizable string name "semicolon-separator" defaulting to "; ".

I am working on a patch.
Comment 1 Roozbeh Pournader 2007-11-18 14:14:27 UTC
Created attachment 4348 [details]
Patch to fix the issue (partially untested)
Comment 2 Roozbeh Pournader 2007-11-18 15:23:32 UTC
Some comments by Nikerabbit on IRC about the patch that I will need to consider:

first is that messages can't end in whitespace
the second thing about the patch is escaping html/parsing
and the third thing is that it could perhaps be cache
afaik changes list does have msgcache like $this->msg or something
Comment 3 Raimond Spekking 2007-12-06 09:42:48 UTC
Optimized for caching and more arabic script languages added. Committed with r28197.

Note You need to log in before you can comment on or make changes to this bug.