Last modified: 2007-12-06 09:42:48 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T13810, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 11810 - Displayed semicolons should be localizable
Displayed semicolons should be localizable
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Internationalization (Other open bugs)
1.12.x
All All
: Normal normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2007-10-29 16:59 UTC by Roozbeh Pournader
Modified: 2007-12-06 09:42 UTC (History)
1 user (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
Patch to fix the issue (partially untested) (2.56 KB, patch)
2007-11-18 14:14 UTC, Roozbeh Pournader
Details

Description Roozbeh Pournader 2007-10-29 16:59:18 UTC
There are different places in MediaWiki that a semicolon is used to separate list of usernames, separate a timestamp from a page name, etc.

These are done using hard-coded strings of semicolon followed by space, '; ', which cannot be localized, as is required for languages that use the Arabic and Syriac scripts, including Persian. Persian uses a different Unicode character for semicolon, namely U+061B, ARABIC SEMICOLON.

Example of such could be seen here:
http://fa.wikipedia.org/wiki/Special:Recentchanges
(search for ;)

All uses of semicolon that is displayed to the user should be localizable. I guess this could be best achieved by definining a localizable string name "semicolon-separator" defaulting to "; ".

I am working on a patch.
Comment 1 Roozbeh Pournader 2007-11-18 14:14:27 UTC
Created attachment 4348 [details]
Patch to fix the issue (partially untested)
Comment 2 Roozbeh Pournader 2007-11-18 15:23:32 UTC
Some comments by Nikerabbit on IRC about the patch that I will need to consider:

first is that messages can't end in whitespace
the second thing about the patch is escaping html/parsing
and the third thing is that it could perhaps be cache
afaik changes list does have msgcache like $this->msg or something
Comment 3 Raimond Spekking 2007-12-06 09:42:48 UTC
Optimized for caching and more arabic script languages added. Committed with r28197.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links