Last modified: 2010-05-15 15:33:36 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T3180, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 1180 - old users not sysopable
old users not sysopable
Product: MediaWiki
Classification: Unclassified
User login and signup (Other open bugs)
All All
: Normal normal (vote)
: ---
Assigned To: Nobody - You can work on this!
: crosswiki
Depends on:
Blocks: 57
  Show dependency treegraph
Reported: 2004-12-23 20:02 UTC by Jason Richey
Modified: 2010-05-15 15:33 UTC (History)
0 users

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

patch to allow sysoping of users (1.16 KB, patch)
2004-12-23 20:30 UTC, Jason Richey

Description Jason Richey 2004-12-23 20:02:53 UTC
If you are running a shared-login setup, then users who sign up on one site can
not be made sysops on a wiki other than the one they signed up for.  The reason
is that the Makesysop.php script uses a left join statement to get the user's id
from the shared user table and their rights from the local user_rights table. 
However, the user_rights table entry is made when the user signs up.  So, only
one site will have a user_rights entry in it's table for the user.  So, the
query turns up null, and any attempt to make the user a sysop results in a query
trying to add sysop rights to the user with id 0.

I've fixed my setup by splitting the join into two queries, so that I always
have the correct user id, regardless of what's in user_rights.
Comment 1 Jason Richey 2004-12-23 20:30:23 UTC
Created attachment 182 [details]
patch to allow sysoping of users

Here is a patch that makes it work, but I know it could be done better...
Comment 2 Brion Vibber 2004-12-23 21:39:56 UTC
It should have been a left _OUTER_ join. Fixed that for both name and ID modes.

Note You need to log in before you can comment on or make changes to this bug.