Last modified: 2013-08-30 22:22:56 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
Bug 11794 - Install DidYouMean extension on the English Wiktionary
Install DidYouMean extension on the English Wiktionary
Status: RESOLVED WONTFIX
Product: Wikimedia
Classification: Unclassified
Extension setup (Other open bugs)
unspecified
All All
: Low enhancement with 1 vote (vote)
: ---
Assigned To: Nobody - You can work on this!
:
: 12329 (view as bug list)
Depends on:
Blocks: 31235
  Show dependency treegraph
 
Reported: 2007-10-28 06:32 UTC by Dominic
Modified: 2013-08-30 22:22 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Dominic 2007-10-28 06:32:33 UTC
As per <http://en.wiktionary.org/wiki/Wiktionary:Votes/2007-08/Extension:_DidYouMean>, the DidYouMean extension (http://svn.wikimedia.org/viewvc/mediawiki/trunk/extensions/DidYouMean/) should be installed on the English Wiktionary. Thanks!
Comment 1 JeLuF 2007-11-04 12:11:58 UTC
The extension needs to be reviewed first. From a first look at it, I'd suggest

* A primary key is always unique. There's no need for the UNIQUE KEY.
* Covering indexes should be used to speed up select queries.
* The preg_replace list in DYMNorm.php looks very expensive. Wouldn't it be 
  faster to use the array form of preg_replace for this, or even Tim's custom
  replace routines.

Changing keywords from "shell" to "need-review"
Comment 2 treauth 2008-03-03 11:14:04 UTC
*** Bug 12329 has been marked as a duplicate of this bug. ***
Comment 3 Connel MacKenzie 2008-03-07 04:47:12 UTC
(In reply to comment #1)
> The extension needs to be reviewed first. From a first look at it, I'd suggest
> 
> * A primary key is always unique. There's no need for the UNIQUE KEY.
> * Covering indexes should be used to speed up select queries.
> * The preg_replace list in DYMNorm.php looks very expensive. Wouldn't it be 
>   faster to use the array form of preg_replace for this, or even Tim's custom
>   replace routines.
> 
> Changing keywords from "shell" to "need-review"
> 


I'm sorry, but that is fundamentally wrong.  In honor of the 100th (or is it 1 millionth?  Who counts?) request, I'll try re-implementing this in Javascript.  It will be painfully slow, and horrifically brutal on the WMF servers, but maybe, just maybe, the lookups people do will direct them to the entries that actually want.
Comment 4 Andrew Dunbar 2008-03-07 05:47:52 UTC
Removing "need-review" flag since Rob Church, Tim Starling, and Brion Vibber all reviewed the code before it was committed to svn. It also ran on Brion's own public test wiki for close to a year with no known bug reports.

It was however my first MediaWiki extension and my first work using SQL so it can surely be improved but none of the points are blockers. Also the original developer, myself, is without a MediaWiki development environment since Brion's cross-country move. Having the current code go live is much more likely to attract improvements than letting it stagnate here for another year.

* The superfluous UNIQUE KEY is superficial and does not affect functionality nor performance.
* I thought the only ways the data was queried were covered by indeces. I did not add any superfluous indeces. However if I missed something I would regard that a minor issue that in any case may require a more experienced SQL developer than me.
* The preg_replace code is certainly ungainly but given that all of the regular expressions are of the very simplest type and the strings to be transformed are short Wiktionary page titles. They are a mustard seed in comparison with the regular expression processing done by the parser. Tim's custom replace routines would be much nicer here but implementing them would require testing whereas the current code is known to work. I'll file an enhancement request but it is no blocker.
Comment 5 Brion Vibber 2008-03-07 20:09:57 UTC
Putting need-review back since I haven't looked at it in ages and would definitely want to look it over again before considering putting it live.
Comment 6 Andrew Dunbar 2008-03-13 04:07:08 UTC
The extension can be tested on a full Wiktioanry mirror from the latest dump at http://70.79.106.1
Comment 7 Andrew Dunbar 2009-02-02 14:29:45 UTC
Sadly this extension is no longer live anywhere I'm aware of.
Comment 8 Siebrand Mazeland 2009-02-02 14:45:16 UTC
r45305 on core and extension MWSearch states: "Make "did you mean" more Googley. It wasn't prominent enough; the red text and bolding should make it more visible, and also more familiar (since I took the styling straight from Google).  I also moved it up way to the top: it *needs* to be one of the first things the user sees to be really useful.  This was particularly terrible on enwiki, where the enormous bloated help message means you have to scroll down through half a page of largely useless nonsense before even seeing the suggestion."

Doesn't that outdate this request?
Comment 9 Andre Klapper 2013-01-23 12:29:46 UTC
See https://www.mediawiki.org/wiki/Writing_an_extension_for_deployment for information on what is needed to get an extension reviewed before potentially deploying it on a wikisite.
Comment 10 Greg Grossmeier 2013-08-22 21:17:09 UTC
Hello, this is a quasi-automated-but-not-really message:

I am reviewing all tracking bugs for extensions to review and deploy to WMF servers. See the list here:
https://bugzilla.wikimedia.org/showdependencytree.cgi?id=31235&hide_resolved=1

The [[mw:Review queue]] page lists the steps necessary to complete the review. I have copied them below and done some initial filling out based on what I can easily gleen from this bug and any linked to sources that are obvious. If I miss something/state something false, please do correct me.

Also, if you haven't yet done so, please review the information on and linked to from:
https://www.mediawiki.org/wiki/Writing_an_extension_for_deployment


== TODO/Check list ==
Extension page on mediawiki.org:
Bugzilla component:
Extension in Gerrit:
Design Review:
Archeticecture/Performance Review:
Security Review:
Screencast (if applicable):
Community support: Yes? Not really anymore?


== Next ==
Given the state of this request, I am inclined to close this bug in the next week if I don't hear back that it is indeed still wanted/useful.

Thanks!
Comment 11 Greg Grossmeier 2013-08-30 22:22:56 UTC
Closing. Feel free to reopen if there is any maintained code to review/community consensus to install.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links