Last modified: 2010-05-15 15:59:41 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
Bug 11733 - Parameter validation in maintenance scripts needs work
Parameter validation in maintenance scripts needs work
Product: MediaWiki
Classification: Unclassified
General/Unknown (Other open bugs)
All All
: Normal minor (vote)
: ---
Assigned To: Brion Vibber
Depends on:
  Show dependency treegraph
Reported: 2007-10-21 20:06 UTC by Karsten Hiddemann
Modified: 2010-05-15 15:59 UTC (History)
0 users

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Description Karsten Hiddemann 2007-10-21 20:06:53 UTC
In maintenance/importTextFile.php (and possible others, haven't checked) you see constructs like the following:

  $title = Title::newFromUrl( $title );
  echo( "\nUsing title '" . $title->getPrefixedText() . "'..." );
  if( is_object( $title ) ) {


  $user = User::newFromName( $user );
  echo( "\nUsing username '" . $user->getName() . "'..." );
  if( is_object( $user ) ) {

When checking if the returned result is an object or not, one shouldn't try to use class functions before the check, of course.
Comment 1 Brion Vibber 2008-12-19 02:04:00 UTC
Fixed in r44792

Note You need to log in before you can comment on or make changes to this bug.